Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the code to handle handwritten resources #17988

Conversation

modular-magician
Copy link
Collaborator

  1. Rewrite the logic to handle handwritten resources. Use Go code to replace common~copy.yaml and common~compile.yaml files.
  2. Convert a couple of .erb handwritten files to .tmpl files.
  3. Remove files that are not compiled to downstream.
    • mmv1/third_party/terraform/utils/provider_versionfive_upgrade_test.go.erb
    • mmv1/third_party/terraform/website/docs/r/compute_firewall_policy_rule.html.markdown

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#10542

[upstream:2832e16ced51f640c45808a98a773b829d4f0542]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit e6cc1e8 into hashicorp:main Apr 29, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
@modular-magician modular-magician deleted the downstream-pr-2832e16ced51f640c45808a98a773b829d4f0542 branch November 17, 2024 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant