Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the code to handle handwritten resources #10542

Merged

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Apr 26, 2024

  1. Rewrite the logic to handle handwritten resources. Use Go code to replace common~copy.yaml and common~compile.yaml files.
  2. Convert a couple of .erb handwritten files to .tmpl files.
  3. Remove files that are not compiled to downstream.
    • mmv1/third_party/terraform/utils/provider_versionfive_upgrade_test.go.erb
    • mmv1/third_party/terraform/website/docs/r/compute_firewall_policy_rule.html.markdown

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 16
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • containeranalysis
  • deploymentmanager

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@zli82016 zli82016 requested a review from c2thorn April 29, 2024 16:14
@zli82016
Copy link
Member Author

cc @NickElliot

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit 2832e16 into GoogleCloudPlatform:main Apr 29, 2024
17 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants