Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back warnings if handwritten conversion files are modified by the Magician #5989

Open
rileykarson opened this issue Mar 26, 2020 · 2 comments
Open

Add back warnings if handwritten conversion files are modified by the Magician #5989

rileykarson opened this issue Mar 26, 2020 · 2 comments
Labels
magician Issues and features related to our bespoke CI service/terraform size/m technical-debt
Milestone
Goals

Comments

@rileykarson
Copy link
Collaborator

We lost this feature going to Magician v2
@rileykarson rileykarson added technical-debt mmv1-generator Provider-wide changes to resource templates or other generator changes labels Mar 26, 2020
@rileykarson rileykarson mentioned this issue Mar 26, 2020
Merged
@danawillow danawillow added this to the Backlog milestone Apr 6, 2020
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue May 6, 2022
@modular-magician
Switch to using folder LIST over SEARCH (hashicorp#5989)
64901d2 
Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit that referenced this issue May 6, 2022
@modular-magician
Switch to using folder LIST over SEARCH (#5989) (#11661)
fd4a387 
Signed-off-by: Modular Magician <[email protected]>
@rileykarson rileykarson changed the title Add back warnings if handwritten validator files are modified to Magician Add back warnings if handwritten validator files are modified by the Magician Jul 17, 2023
@rileykarson rileykarson changed the title Add back warnings if handwritten validator files are modified by the Magician Add back warnings if handwritten conversion files are modified by the Magician Jul 17, 2023
@rileykarson rileykarson modified the milestones: Backlog, Goals Jul 17, 2023
@rileykarson
Copy link
Collaborator Author

Note: I am not sure the warning was ever particularly effective

@melinath
Copy link
Collaborator

b/233927646

@rileykarson rileykarson added magician Issues and features related to our bespoke CI and removed mmv1-generator Provider-wide changes to resource templates or other generator changes labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
magician Issues and features related to our bespoke CI service/terraform size/m technical-debt
Projects
None yet
Milestone
Goals
Development

No branches or pull requests
3 participants
@melinath @danawillow @rileykarson