-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GKE Resource Consumption Metering, promote resource export to GA #3303
Add GKE Resource Consumption Metering, promote resource export to GA #3303
Conversation
I think this file also needs to be updated: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/third_party/validator/container.go Somewhat off topic, but I thought we had some CI which would detect drift in manually written resources for conversion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
resource_usage_export_config { | ||
enable_network_egress_metering = true | ||
|
||
enable_resource_consumption_metering = %s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: indentation
@morgante: Filed hashicorp/terraform-provider-google#5988 to resync container cluster, hashicorp/terraform-provider-google#5989 to get the Magician to warn us again |
Thanks @rileykarson! |
…leCloudPlatform#3303) * Add GKE Resource Consumption Metering, promote resource export to GA * Add docs * Spacing
Fixes hashicorp/terraform-provider-google#4634, supersedes #2705
Test changes are a little messy, I got rid of a conditional block and made it two cases instead.
Release Note Template for Downstream PRs (will be copied)