Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new beta features for PubSub subscriptions #2507

Closed
rolandkool opened this issue Nov 21, 2018 · 4 comments · Fixed by GoogleCloudPlatform/magic-modules#1703
Closed
Assignees

Comments

@rolandkool
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Subscriptions are expired by GCP automatically after 31 days of inactivity. The lifecycle can be configured using a beta feature. It would be nice and useful if terraform would support this. Additional new options for retaining ack'd messages and message retention duration could be supported as well.

Also, if a subscription gets removed by GCP due to inactivity and terraform runs, it needs to be able to recreate it without error.

New or Affected Resource(s)

  • google_pubsub_subscription

Potential Terraform Configuration

resource "google_pubsub_subscription" "default" {
  name  = "default-subscription"
  topic = "${google_pubsub_topic.default-topic.name}"

  retain_acked_messages = false
  message_retention_duration = "15m"
  expiration_policy {
    ttl: "15d"
  }
}

References

https://cloud.google.com/pubsub/docs/subscriber#lifecycle
https://cloud.google.com/pubsub/docs/subscriber#expiration
https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.subscriptions/create

@ghost ghost added the enhancement label Nov 21, 2018
@rileykarson
Copy link
Collaborator

@rolandkool
Copy link
Contributor Author

@rileykarson Indeed, it would be nice if that got supported as well. If you are working on this, would it be possible to also check out #3210?
Thanks

@tysen
Copy link

tysen commented May 3, 2019

Referenced PR fixes this.

@ghost
Copy link

ghost commented Jun 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants