Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubSub topic does not support Update #3210

Closed
rolandkool opened this issue Mar 11, 2019 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#1900
Closed

PubSub topic does not support Update #3210

rolandkool opened this issue Mar 11, 2019 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#1900

Comments

@rolandkool
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Google provider version 2.1.0

Affected Resource(s)

  • google_pubsub_topic

Expected Behavior

Labels are changed without creating a new resource.

The gcloud command supports updating the labels on existing resources:

gcloud alpha pubsub topics update mytopic --update-labels key=value --project myproject

Actual Behavior

Terraform creates a new resource:
labels.%: "4" => "5" (forces new resource)

Steps to Reproduce

Create a topic resource using terraform and then add or change something in the label arguments.

References

@ghost ghost added the bug label Mar 11, 2019
@chrisst chrisst self-assigned this Mar 18, 2019
@chrisst chrisst changed the title Updating labels on PubSub topic forces new resource PubSub topic does not support Update Mar 20, 2019
@chrisst chrisst added enhancement and removed bug labels Mar 20, 2019
@chrisst chrisst removed their assignment Mar 20, 2019
@ghost
Copy link

ghost commented Jul 15, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants