-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expiration policy to pubsub subscription resource #1703
Add expiration policy to pubsub subscription resource #1703
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNew Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update one of the PubSub examples (https://github.com/GoogleCloudPlatform/magic-modules/tree/master/templates/terraform/examples) to use the new field so users see how to configure it + we test it?
It could also be worth specifying in the ttl
field docs how it's specified.
Added both, along with a DSF for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM.
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Fixes hashicorp/terraform-provider-google#2507
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]