Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expiration policy to pubsub subscription resource #1703

Merged
merged 2 commits into from
May 3, 2019
Merged

Add expiration policy to pubsub subscription resource #1703

merged 2 commits into from
May 3, 2019

Conversation

tysen
Copy link

@tysen tysen commented Apr 30, 2019

Fixes hashicorp/terraform-provider-google#2507


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@tysen tysen requested a review from rileykarson April 30, 2019 23:47
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 21fecd64710dec363c572b58274c8040bd7ca722.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#648
depends: GoogleCloudPlatform/terraform-google-conversion#68
depends: hashicorp/terraform-provider-google#3525
depends: modular-magician/ansible#240
depends: modular-magician/inspec-gcp#153

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update one of the PubSub examples (https://github.com/GoogleCloudPlatform/magic-modules/tree/master/templates/terraform/examples) to use the new field so users see how to configure it + we test it?

It could also be worth specifying in the ttl field docs how it's specified.

@tysen
Copy link
Author

tysen commented May 3, 2019

Added both, along with a DSF for expirationPolicy.ttl.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 923e3e9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

Ty Larrabee and others added 2 commits May 3, 2019 18:35
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new beta features for PubSub subscriptions
4 participants