Don't send update request if updatemask is empty for resources with terraform_labels field #6443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erraform_labels field (#9154) * Don't send update request if updatmask is empty when resource has terraform_labels * Remove the function check field_specific_update_methods * Set project to billing project for google_network_security_address_group * Change back of project for resource google_network_security_address_group [upstream:c6531043f144daec5952b4af2ccf0ace9d3959b4] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-c6531043f144daec5952b4af2ccf0ace9d3959b4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#16091
If the updateMask is empty, it means that no update is needed. The update request is not needed to be sent.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9154