Don't send update request if updatemask is empty for resources with terraform_labels field

[zli82016]

Fixes hashicorp/terraform-provider-google#16091

If the updateMask is empty, it means that no update is needed. The update request is not needed to be sent.

Release Note Template for Downstream PRs (will be copied)

provider: fixed the bug that update request is sent to services when updateMask is empty

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 59 files changed, 1261 insertions(+), 1031 deletions(-))
Terraform Beta: Diff ( 76 files changed, 1629 insertions(+), 1346 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 60 files changed, 1277 insertions(+), 1043 deletions(-))
Terraform Beta: Diff ( 77 files changed, 1645 insertions(+), 1358 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 60 files changed, 1277 insertions(+), 1043 deletions(-))
Terraform Beta: Diff ( 77 files changed, 1645 insertions(+), 1358 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 59 files changed, 1271 insertions(+), 1037 deletions(-))
Terraform Beta: Diff ( 76 files changed, 1639 insertions(+), 1352 deletions(-))

[zli82016]

It looks like there is a bug in terraform-google-conversion-build-and-unit-tests. It is still checking the previous revision of this PR.

[c2thorn]

Is https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown?plain=1#L100 still accurate after this PR? Should it be updated?

[rileykarson]

It's still accurate. The problem is that we're calling Terraform's Update method which eventually sends a spurious Patch/Post to the API. This change will guard against sending that Patch/Post.

[modular-magician]

Tests analytics

Total tests: 3113
Passed tests 2793
Skipped tests: 315
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_withAddons|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 158 files changed, 3151 insertions(+), 2550 deletions(-))
Terraform Beta: Diff ( 198 files changed, 4001 insertions(+), 3271 deletions(-))

[rileykarson]

Looks like the build failing is just a case of

magic-modules/mmv1/templates/terraform/post_update/cloudbuild_bitbucketserver_config.go.erb

Line 24 in 48937a7

res, err = transport_tpg.SendRequest(transport_tpg.SendRequestOptions{

assuming res would already exist. You can declare res or change it to instantiate in that line by making it :=

Looking into addressgroups to see if that transformation is safe

[zli82016]

Looks like the build failing is just a case of

magic-modules/mmv1/templates/terraform/post_update/cloudbuild_bitbucketserver_config.go.erb

Line 24 in 48937a7

res, err = transport_tpg.SendRequest(transport_tpg.SendRequestOptions{

assuming res would already exist. You can declare res or change it to instantiate in that line by making it :=
Looking into addressgroups to see if that transformation is safe

Yeah, made the change.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 158 files changed, 3153 insertions(+), 2552 deletions(-))
Terraform Beta: Diff ( 198 files changed, 4003 insertions(+), 3273 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 158 files changed, 3153 insertions(+), 2552 deletions(-))
Terraform Beta: Diff ( 198 files changed, 4003 insertions(+), 3273 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3116
Passed tests 2797
Skipped tests: 315
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_withAddons|TestAccContainerNodePool_withKubeletConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[zli82016]

Actually, this line is before getting billingProject in update and delete method in the generated file and isn't working as expected
https://github.com/modular-magician/terraform-provider-google-beta/blob/be49b211522d9e2b34b84ff66268f8a9f8be5bf0/google-beta/services/networksecurity/resource_network_security_address_group.go#L366

Is it safe to move the pre_update just from line 776 to line 794 before the line of sendRequest in template file resource.erb? (The same action for pre_delete)

[rileykarson]

Good catch! Let's make these "" in that case. Can you file an issue to fix the inconsistency in where pre_ methods are? That should happen in a dedicated PR.

[zli82016]

Sure. I will file an issue.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 159 files changed, 3153 insertions(+), 2567 deletions(-))
Terraform Beta: Diff ( 199 files changed, 4003 insertions(+), 3288 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3117
Passed tests 2799
Skipped tests: 315
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withAddons|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withKubeletConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test