Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer access control #2075

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#6106

Release Note Template for Downstream PRs (will be copied)

composer: Added support for `google_composer_environment` `web_server_network_access_control` for private environments (Beta only)
composer: Added support for `google_composer_environment` `config.private_environment_config.cloud_sql_ipv4_cidr_block`
composer: Added support for `google_composer_environment` `config.private_environment_config.web_server_ipv4_cidr_block`

Derived from GoogleCloudPlatform/magic-modules#3503

* Create works, update needs help

* non-plural name for set items

* Add sql and web server ip cidr blocks

* Test passes

* Remove schema from ga version, fix lint erro

* Add note to composer docs linking to private environment setup

* Computed web server access as it has default values set by API. Ignore during import tests

* Add computed to new cidr blocks as they get default values based on the region they exist in

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 55a8235 into hashicorp:master May 15, 2020
@modular-magician modular-magician deleted the downstream-pr-11b8d2fbec1532bb4bbc0abb29a19f439e6f5cdb branch November 16, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer environment fields are missing, one is required to create private environments
1 participant