Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old tools (Ansible, InSpec) from the Magician #3503

Conversation

modular-magician
Copy link
Collaborator

Part of hashicorp/terraform-provider-google#9588

I believe I can roll forward this change without updating the downstream-builder image as the behaviour is opt-in, although I've cleaned it up for the next rebuild. I will update github-differ prior to merging, but haven't yet. That will mean:

  • Old PRs will continue to work, generating downstreams, but those changes will never get synced or commented about
  • New PRs, or PRs that rebase will no longer generate downstreams

When we next rebuild downstream-builder, old PRs that have not rebased will report an unrecognized repo error, but there will be less of them. We could also rebuild now, but that'll cause a lot more noise.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#5069

@modular-magician modular-magician merged commit 7f696b9 into hashicorp:master Aug 10, 2021
@modular-magician modular-magician deleted the downstream-pr-33b28513959716e7cc072be602873c1fe7c81bed branch November 16, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant