Vcr ignore tests #2069
Merged
Vcr ignore tests #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Missed acctest.Randoms, add support for skipIfVcr * Add skip_vcr to tests, more fixes for failing vcr tests * Fix compile * Comment on why / path replace is needed * Rubocop line length * Ignores for instance template tests with generated ids, multiple fine-grained resources in single step * Add more ignores, rework VCR file writing to only write when test succeeds * Add notes on why specific tests fail VCR * Spaces... Signed-off-by: Modular Magician <[email protected]>
ghost
added
the
modular-magician
deleted the
downstream-pr-269619ff4776a3059c1de63ad93bcdd343e3554d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ignoring tests during VCR test runs. Fix more tests
Move writing new seeds to the end of a test process alongside writing the cassette yaml. This prevents the seed and yaml from getting out of sync if a test fails during RECORDING mode.
~20 tests failing at this point
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3486