New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vcr ignore tests #3486

Merged

slevenick merged 9 commits into GoogleCloudPlatform:master from slevenick:vcr-ignore-tests

May 14, 2020

Contributor

slevenick commented May 8, 2020 •

edited

Loading

Add support for ignoring tests during VCR test runs. Fix more tests

Move writing new seeds to the end of a test process alongside writing the cassette yaml. This prevents the seed and yaml from getting out of sync if a test fails during RECORDING mode.

~20 tests failing at this point

Release Note Template for Downstream PRs (will be copied)

googlebot added the cla: yes label

Collaborator

modular-magician commented May 8, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 22 files changed, 65 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 26 files changed, 69 insertions(+), 29 deletions(-))
TF Conversion: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

Collaborator

modular-magician commented May 8, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 22 files changed, 66 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 26 files changed, 70 insertions(+), 29 deletions(-))
TF Conversion: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

1 similar comment

Collaborator

modular-magician commented May 8, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 22 files changed, 66 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 26 files changed, 70 insertions(+), 29 deletions(-))
TF Conversion: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

Collaborator

modular-magician commented May 10, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 31 files changed, 81 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 34 files changed, 85 insertions(+), 29 deletions(-))
TF Conversion: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

slevenick force-pushed the vcr-ignore-tests branch from 56f3294 to a4b914d Compare

May 11, 2020 06:38

Collaborator

modular-magician commented May 11, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 30 files changed, 80 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 34 files changed, 84 insertions(+), 29 deletions(-))
TF Conversion: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

Collaborator

modular-magician commented May 11, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 34 files changed, 123 insertions(+), 39 deletions(-))
Terraform Beta: Diff ( 38 files changed, 127 insertions(+), 47 deletions(-))
TF Conversion: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

slevenick requested a review from danawillow

May 12, 2020 16:38

danawillow reviewed

View reviewed changes

products/compute/terraform.yaml Show resolved Hide resolved

Collaborator

modular-magician commented May 13, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 34 files changed, 153 insertions(+), 39 deletions(-))
Terraform Beta: Diff ( 38 files changed, 157 insertions(+), 47 deletions(-))
TF Conversion: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

slevenick requested a review from danawillow

May 13, 2020 18:23

Collaborator

modular-magician commented May 13, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 34 files changed, 153 insertions(+), 39 deletions(-))
Terraform Beta: Diff ( 38 files changed, 157 insertions(+), 47 deletions(-))
TF Conversion: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

danawillow approved these changes

View reviewed changes

slevenick added 9 commits

May 13, 2020 17:00


          Missed acctest.Randoms, add support for skipIfVcr

7f9a94a


          Add skip_vcr to tests, more fixes for failing vcr tests

404163c


          Fix compile

cf4fd83


          Comment on why / path replace is needed


          Rubocop line length

1c14af2


          Ignores for instance template tests with generated ids, multiple fine…

632bc3a

…-grained resources in single step


          Add more ignores, rework VCR file writing to only write when test suc…

ad884c0

…ceeds


          Add notes on why specific tests fail VCR

f429ab3


          Spaces...

4ef8220

slevenick force-pushed the vcr-ignore-tests branch from 818b357 to 4ef8220 Compare

May 14, 2020 00:01

Collaborator

modular-magician commented May 14, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 34 files changed, 153 insertions(+), 39 deletions(-))
Terraform Beta: Diff ( 38 files changed, 157 insertions(+), 47 deletions(-))
TF Conversion: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

slevenick merged commit 269619f into GoogleCloudPlatform:master

This was referenced May 14, 2020

Vcr ignore tests GoogleCloudPlatform/terraform-google-conversion#438

Merged

Vcr ignore tests hashicorp/terraform-provider-google#6375

Merged

Vcr ignore tests hashicorp/terraform-provider-google-beta#2069

Merged

nathkn pushed a commit to nathkn/magic-modules that referenced this pull request


          Vcr ignore tests (GoogleCloudPlatform#3486)

ed44c35

* Missed acctest.Randoms, add support for skipIfVcr

* Add skip_vcr to tests, more fixes for failing vcr tests

* Fix compile

* Comment on why / path replace is needed

* Rubocop line length

* Ignores for instance template tests with generated ids, multiple fine-grained resources in single step

* Add more ignores, rework VCR file writing to only write when test succeeds

* Add notes on why specific tests fail VCR

* Spaces...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels