Fix metadata for storage bucket object #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <[email protected]>
ghost
added
the
modular-magician
deleted the
downstream-pr-1f5b6ab917b646ba0426db10b761244e56899daa
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
Fixes hashicorp/terraform-provider-google#6256
This wasn't caught by the metadata test because the absence of the field in both create and read - resource.TestCheckResourceAttr checks against state, where metadata was never changed from the initial config value. Usually this is fixed by the import tests.
I don't think storage bucket object is out of the range of autogenerating, so I'll probably do that in a follow-up PR. At the very least, we should support import, though I'm not sure if we avoided it because of content/source.
Derived from GoogleCloudPlatform/magic-modules#3458