Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata for storage bucket object #3458

Merged
merged 1 commit into from
May 1, 2020

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented May 1, 2020

Release Note Template for Downstream PRs (will be copied)

storage: Fixed setting/reading `google_storage_bucket_object`  metadata on API object

Fixes hashicorp/terraform-provider-google#6256

This wasn't caught by the metadata test because the absence of the field in both create and read - resource.TestCheckResourceAttr checks against state, where metadata was never changed from the initial config value. Usually this is fixed by the import tests.

I don't think storage bucket object is out of the range of autogenerating, so I'll probably do that in a follow-up PR. At the very least, we should support import, though I'm not sure if we avoided it because of content/source.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 6 insertions(+))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+))

@emilymye emilymye requested a review from rileykarson May 1, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_storage_bucket_object not setting metadata
4 participants