Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upstream] Standardize google_compute_instance import #1933

Conversation

modular-magician
Copy link
Collaborator

Upstreams hashicorp/terraform-provider-google#6023

Release Note Template for Downstream PRs (will be copied)

compute: Added more import formats for `google_compute_instance`

Derived from GoogleCloudPlatform/magic-modules#3329

* Standardize google_compute_instance import ID

This patch changes the import ID of google_compute_instance to have a
format that is more consistent with other resources like
google_compute_subnetwork while still supporting the previously
supported import ID of {{project}}/{{zone}}/{{name}} in order to have
backwards compatibility.

* Standardize google_compute_instance import ID

This patch changes the import ID of google_compute_instance to have a
format that is more consistent with other resources like
google_compute_subnetwork while still supporting the previously
supported import ID of {{project}}/{{zone}}/{{name}} in order to have
backwards compatibility.

Co-authored-by: Jazel Canseco <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 665b641 into hashicorp:master Apr 6, 2020
@modular-magician modular-magician deleted the downstream-pr-77e1f674b4538d7da316dfe9645e2e645420f8aa branch November 16, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant