Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upstream] Standardize google_compute_instance import #3329

Merged
merged 2 commits into from
Apr 6, 2020
Merged

[Upstream] Standardize google_compute_instance import #3329

merged 2 commits into from
Apr 6, 2020

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Apr 1, 2020 •
edited
Loading

Upstreams hashicorp/terraform-provider-google#6023

Release Note Template for Downstream PRs (will be copied)

compute: Added more import formats for `google_compute_instance`

@emilymye emilymye force-pushed the upstream_import_compute branch from f10de87 to baec1a4 Compare April 1, 2020 22:22
@emilymye emilymye requested a review from slevenick April 1, 2020 22:22
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 17 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 2 files changed, 17 insertions(+), 11 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 17 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 2 files changed, 17 insertions(+), 11 deletions(-))

slevenick
slevenick requested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downstream PR changed to not modify the id format. Can you update that?

jcanseco added 2 commits April 3, 2020 10:29
@jcanseco @emilymye
Standardize google_compute_instance import ID
efcb4e6 
This patch changes the import ID of google_compute_instance to have a
format that is more consistent with other resources like
google_compute_subnetwork while still supporting the previously
supported import ID of {{project}}/{{zone}}/{{name}} in order to have
backwards compatibility.
@jcanseco @emilymye
Standardize google_compute_instance import ID
1db4f10 
This patch changes the import ID of google_compute_instance to have a
format that is more consistent with other resources like
google_compute_subnetwork while still supporting the previously
supported import ID of {{project}}/{{zone}}/{{name}} in order to have
backwards compatibility.
@emilymye emilymye force-pushed the upstream_import_compute branch from baec1a4 to 1db4f10 Compare April 3, 2020 17:29
@emilymye emilymye requested a review from slevenick April 3, 2020 17:29
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 17 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 17 insertions(+), 10 deletions(-))

@emilymye emilymye merged commit 77e1f67 into GoogleCloudPlatform:master Apr 6, 2020
@modular-magician modular-magician mentioned this pull request Apr 6, 2020
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@emilymye @jcanseco
[Upstream] Standardize google_compute_instance import (GoogleCloudPla…
f7fa802 
…tform#3329)

* Standardize google_compute_instance import ID

This patch changes the import ID of google_compute_instance to have a
format that is more consistent with other resources like
google_compute_subnetwork while still supporting the previously
supported import ID of {{project}}/{{zone}}/{{name}} in order to have
backwards compatibility.

* Standardize google_compute_instance import ID

This patch changes the import ID of google_compute_instance to have a
format that is more consistent with other resources like
google_compute_subnetwork while still supporting the previously
supported import ID of {{project}}/{{zone}}/{{name}} in order to have
backwards compatibility.

Co-authored-by: Jazel Canseco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevenick slevenick slevenick approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emilymye @modular-magician @slevenick @googlebot @jcanseco