Update data source azurerm_policy_definition: Make name as a possible input variable

[ArcturusZhang]

Fixes #6249

And I temporarily removed the validation function of management group id, since it will never be a resource ID here, it should be an UUID or some proper name of a management group, rather than a full ID. (And a mgmt group full ID is also not a valid resource ID)

[ArcturusZhang]

Acc tests are passing:

[katbyte]

Thanks for the PR @ArcturusZhang,

Aside from a few minor comments i've left inline this looks good, should be good to merge once the they are addressed 🙂

[ArcturusZhang]

Hi @katbyte thanks for the review! I have made some changes that resolves those comments, and deprecate the old management_group_id field (both data source and resource) to align with the recent changes in management groups. Please have a look, thanks!

[katbyte]

Thanks for this @ArcturusZhang! hope you don't mind but i pushed a couple changed to get this merged 🙂 LGTM !

[ghost]

This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.6.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!