Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azurerm_policy_definition lookup by definition_id #6249

Closed
rohrerb opened this issue Mar 25, 2020 · 4 comments · Fixed by #6275
Closed

data.azurerm_policy_definition lookup by definition_id #6249

rohrerb opened this issue Mar 25, 2020 · 4 comments · Fixed by #6275

Comments

@rohrerb
Copy link
Contributor

rohrerb commented Mar 25, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

DisplayName is not consistent across clouds (gov vs commerial) but policy_definition_id is consistent.

New or Affected Resource(s)

data "azurerm_policy_definition" "example" {
policy_definition_id= ""
}

Potential Terraform Configuration

data "azurerm_policy_definition" "example" {
  policy_definition_id= "<some-guid>"
}
@rohrerb
Copy link
Contributor Author

rohrerb commented Mar 25, 2020

This could also resolve #5883

@ArcturusZhang
Copy link
Contributor

Hi @rohrerb Thanks for this issue!
Actually the field you are intending to add should be name of the policy definition.
I am currently working on this. Should be able to open a PR fixing this.
Or are you meaning the full ID, like /subscription/{subsID}/providers/Microsoft.Authorization/policyDefinitions/def1? I suppose when you have the ID and want to get some information from the resource, you should use import rather than a data source.

@katbyte katbyte added this to the v2.5.0 milestone Apr 8, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.5.0, v2.6.0 Apr 8, 2020
katbyte pushed a commit that referenced this issue Apr 9, 2020
Fixes #6249

And I temporarily removed the validation function of management group id, since it will never be a resource ID here, it should be an UUID or some proper name of a management group, rather than a full ID. (And a mgmt group full ID is also not a valid resource ID)
@ghost
Copy link

ghost commented Apr 16, 2020

This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.6.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants