Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

express_route_* - split createupdate in express_route_ #26237

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

catriona-m
Copy link
Member

@catriona-m catriona-m commented Jun 5, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This pr splits out the createupdate functions in the following resources:

  • azurerm_express_route_circuit_peering
  • azurerm_express_route_circuit
  • azurerm_express_route_gateway
  • azurerm_express_route_port

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Tests passing in TC aside from ones already failing in main

@catriona-m catriona-m marked this pull request as draft June 5, 2024 12:47
@catriona-m catriona-m marked this pull request as ready for review June 7, 2024 12:43
@catriona-m catriona-m requested a review from a team June 7, 2024 12:43
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catriona-m, aside from one minor comment LGTM 🐼

@catriona-m catriona-m merged commit 268cf99 into main Jun 10, 2024
31 checks passed
@catriona-m catriona-m deleted the cm/expressroutesplit branch June 10, 2024 13:21
@github-actions github-actions bot added this to the v3.108.0 milestone Jun 10, 2024
catriona-m added a commit that referenced this pull request Jun 10, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Jun 18, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.107.0&#34; to &#34;3.108.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.108.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.108.0&#xA;FEATURES:&#xA;&#xA;*
**New Data Source:** `azurerm_role_management_policy`
([#25900](hashicorp/terraform-provider-azurerm#25900
**New Resource:** `azurerm_role_management_policy`
([#25900](https://github.com/hashicorp/terraform-provider-azurerm/issues/25900))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
provider: support subscription ID hinting when using Azure CLI
authentication
([#26282](hashicorp/terraform-provider-azurerm#26282
`serviceconnector`: updating to use API Version `2024-04-01`
([#26248](hashicorp/terraform-provider-azurerm#26248
`azurerm_container_groups` - can now be created with a User Assigned
Identity when running Windows
([#26308](hashicorp/terraform-provider-azurerm#26308
`azurerm_kubernetes_cluster` - updating the
`network_profile.network_policy` property to `azure` and `calico` when
it hasn&#39;t been previously set is supported
([#26176](hashicorp/terraform-provider-azurerm#26176
`azurerm_kubernetes_cluster` - respect Pod Distruption Budgets when
rotating the `default_node_pool`
([#26274](hashicorp/terraform-provider-azurerm#26274
`azurerm_lb_backend_address_pool` - support for the `synchronous_mode`
property
([#26309](hashicorp/terraform-provider-azurerm#26309
`azurerm_private_endpoint` - support symultaneous creation of multiple
resources of this type per subnet
([#26006](https://github.com/hashicorp/terraform-provider-azurerm/issues/26006))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azurerm_express_route_circuit_peering`,
`azurerm_express_route_circuit`, `azurerm_express_route_gateway`,
`azurerm_express_route_port` - split create and update
([#26237](hashicorp/terraform-provider-azurerm#26237
`azurerm_lb_backend_address_pool_address` - when using this resource,
values are no longer reset on `azurerm_lb_backend_address_pool`
([#26264](hashicorp/terraform-provider-azurerm#26264
`azurerm_route_filter` - spliting create and update so lifecycle ignore
changes works correctly
([#26266](hashicorp/terraform-provider-azurerm#26266
`azurerm_route_server` - spliting create and update so lifecycle ignore
changes works correctly
([#26266](hashicorp/terraform-provider-azurerm#26266
`azurerm_synapse_workspace` - updates the client used in all operations
of `azurerm_synapse_workspace_sql_aad_admin` to prevent this resource
from modifying the same resource as
`azurerm_synapse_workspace_aad_admin`
([#26317](hashicorp/terraform-provider-azurerm#26317
`azurerm_virtual_network` - correctly parse network securty group IDs
([#26283](https://github.com/hashicorp/terraform-provider-azurerm/issues/26283))&#xA;&#xA;DEPRECATIONS:&#xA;&#xA;*
Data Source: `azurerm_network_interface` - the `enable_ip_forwarding`
and `enable_accelerated_networking` properties have been deprecated and
superseded by the `ip_forwarding_enabled` and
`accelerated_networking_enabled` properties
([#26293](hashicorp/terraform-provider-azurerm#26293
`azurerm_api_management` - the `policy` block has been deprecated is
superseded by the `azurerm_api_management_policy` resource
([#26305](hashicorp/terraform-provider-azurerm#26305
`azurerm_kubernetes_cluster` - the `ebpf_data_plane` property has been
deprecated and superseded by the `network_data_plane` property
([#26251](hashicorp/terraform-provider-azurerm#26251
`azurerm_network_interface` - the `enable_ip_forwarding` and
`enable_accelerated_networking` properties have been deprecated and
superseded by the `ip_forwarding_enabled` and
`accelerated_networking_enabled` properties
([#26293](hashicorp/terraform-provider-azurerm#26293
`azurerm_synapse_workspace` - the `aad_admin` and `sql_aad_admin` blocks
have been deprecated and superseded by the
`azurerm_synapse_workspace_aad_admin` and
`azurerm_synapse_workspace_sql_aad_admin` resources
([#26317](https://github.com/hashicorp/terraform-provider-azurerm/issues/26317))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/244/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants