azurerm_logic_app_trigger_custom - adding exported attribute callback_url

[nickel-tyler]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

adds callback_url for azurerm_logic_app_trigger_custom. check occurs in logic_apps.retrieveLogicAppTrigger to get url if trigger is of relevant type. fixes #25623

PR Checklist

• [ x ] I have followed the guidelines in our Contributing Documentation.
• [ x ] I have checked to ensure there aren't other open Pull Requests for the same update/change.
• [ x ] I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• [ x ] I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• [ x ] I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• [ x ] I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• [ x ] I have written new tests for my resource or datasource changes & updated any relevent documentation.
• [ x ] I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• [ x ] My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

=== CONT TestAccLogicAppTriggerRecurrence_second
testcase.go:113: TestCase error running init: exit status 1

    Error: Failed to install provider
    
    Error while installing hashicorp/tls v4.0.4: releases.hashicorp.com: Get
    "https://releases.hashicorp.com/terraform-provider-tls/4.0.4/terraform-provider-tls_4.0.4_darwin_arm64.zip":
    write tcp
    [fe80::fae4:3bff:fecb:82c5%utun5]:57517->[2600:9000:254a:f600:5:e2b6:b380:93a1]:443:
    write: socket is not connected

--- FAIL: TestAccLogicAppTriggerRecurrence_second (11.32s)
--- PASS: TestAccLogicAppTriggerRecurrence_day (71.30s)
--- PASS: TestAccLogicAppTriggerRecurrence_startTime (73.47s)
--- PASS: TestAccLogicAppTriggerRecurrence_minute (75.58s)
--- PASS: TestAccLogicAppTriggerRecurrence_hour (77.93s)
--- PASS: TestAccLogicAppTriggerRecurrence_requiresImport (80.49s)
--- PASS: TestAccLogicAppTriggerRecurrence_month (82.63s)
--- PASS: TestAccLogicAppTriggerRecurrence_week (84.76s)
--- PASS: TestAccLogicAppTriggerRecurrence_startTimeWithTimeZone (88.42s)
--- PASS: TestAccLogicAppTriggerRecurrence_update (103.60s)
--- PASS: TestAccLogicAppTriggerRecurrence_schedule (111.46s)
--- PASS: TestAccLogicAppTriggerRecurrence_timeZone (151.50s)
FAIL
FAIL github.com/hashicorp/terraform-provider-azurerm/internal/services/logic 153.197s
FAIL

=== RUN TestAccLogicAppTriggerCustom_callbackUrlider-azurerm> .\test.ps1
=== PAUSE TestAccLogicAppTriggerCustom_callbackUrl
=== RUN TestAccLogicAppTriggerCustom_callbackUrl2
=== PAUSE TestAccLogicAppTriggerCustom_callbackUrl2
=== CONT TestAccLogicAppTriggerCustom_callbackUrl
=== CONT TestAccLogicAppTriggerCustom_callbackUrl2
--- PASS: TestAccLogicAppTriggerCustom_callbackUrl (58.77s)
--- PASS: TestAccLogicAppTriggerCustom_callbackUrl2 (61.96s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/logic 63.689s
=== RUN TestAccLogicAppTriggerHttpRequest_callbackUrlazurerm> .\test.ps1
=== PAUSE TestAccLogicAppTriggerHttpRequest_callbackUrl
=== CONT TestAccLogicAppTriggerHttpRequest_callbackUrl
--- PASS: TestAccLogicAppTriggerHttpRequest_callbackUrl (54.58s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/logic 56.306s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_logic_app_trigger_custom - support for the callback_url property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• [ x ] Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks for this PR @nickel-tyler! I left some suggestions in-line, once they're resolved this should be good to go!

[nickel-tyler]

@stephybun the requested changes have been submitted. Thank you for taking a look

[stephybun]

Tests look good

Thanks @nickel-tyler LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.