-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_container_app_environment
- Support for Mutual TLS added
#25993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jhisc 0- overall looks good i just have 1 minor comment i've left inline. Once that is addressed i think this is good to merge provided tests pass
internal/services/containerapps/container_app_environment_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/containerapps/container_app_environment_resource_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @jhisc! I have two comments/questions on this PR. Would you mind taking a look? Once they're resolved this should be good to go
internal/services/containerapps/container_app_environment_resource.go
Outdated
Show resolved
Hide resolved
Thanks! Both comments have been resolved 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhisc nearly there, could you rebase your branch on top of main? That should fix the Vendor dependencies check and then we can run the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good, thanks @jhisc LGTM 💯
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
Adding support for Mutual TLS within Azure Container App Environments.
This is a non breaking change and backwards compatable.
Changes can be made to existing resources without requiring a re-creation.
Defaults to
false
which results in a no-changes to existing infrastructure.Provider tested to validate:
Feature enhancement - Not a major chance, optional input
PR looks worse than it is, vast majority of changed files are the new SDK version being pulled into the Vendor folder.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_container_app_environment
- support for the MTLS property [azurerm_container_app_environment
- Support for Mutual TLS added #25993]This is a (please select all that apply):
Related Issue(s)
Resolves #21960
Note
If this PR changes meaningfully during the course of review please update the title and description as required.