Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic App: Add callback url as attribute of custom trigger #25623

Closed
1 task done
nickel-tyler opened this issue Apr 15, 2024 · 4 comments · Fixed by #25979
Closed
1 task done

Logic App: Add callback url as attribute of custom trigger #25623

nickel-tyler opened this issue Apr 15, 2024 · 4 comments · Fixed by #25979

Comments

@nickel-tyler
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

Please add the ability to make use of the callback url from the ListCallbackURL azure sdk api for a given custom trigger so that the logic app can be hooked up to other infrastructure.

My particular use case is i'm trying to use terraform to manage the creation of a logic app and a security center automation that should be configured to trigger that logic app. azurerm_security_center_automation requires action.trigger_url, even if using built in connectors for the logic app triggers. azurerm_logic_app_trigger_http_request could be used instead according to https://learn.microsoft.com/en-us/azure/defender-for-cloud/workflow-automation#data-types-schemas, but I think the built-in connectors should be supported with TF too.

New or Affected Resource(s)/Data Source(s)

azurerm_logic_app_trigger_custom and/or azurerm_security_center_automation

Potential Terraform Configuration

No response

References

https://github.com/Azure/azure-sdk-for-go/blob/a45cf26fd136c65f9ca4f00405c5ccce7b3941e3/sdk/resourcemanager/logic/armlogic/workflows_client.go
#3724
https://learn.microsoft.com/en-us/azure/defender-for-cloud/workflow-automation#data-types-schemas

@nickel-tyler
Copy link
Contributor Author

I've got a branch mostly done, but am struggling to get a debug environment running on my crappy corporate computer. The only thing that needs to be added is a check to ignore 404/ApiNotSupported when calling ListCallbackUrl for a custom trigger, and to populate it as blank on the model in this case.

https://github.com/hashicorp/terraform-provider-azurerm/compare/main...nickel-tyler:terraform-provider-azurerm:trigger-callback-url?diff=split&w=

@vil2be
Copy link

vil2be commented May 10, 2024

@nickel-tyler @mybayern1974 any update on this? much appreciated :)

@nickel-tyler
Copy link
Contributor Author

@vil2be I'll make a pr tomorrow

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants