Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Switch to Go Modules #7165

Merged
merged 1 commit into from
Jan 16, 2019
Merged

provider: Switch to Go Modules #7165

merged 1 commit into from
Jan 16, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 16, 2019

Remove govendor for dependency management and add service clients for new services we want to vendor.

go mod init
go mod tidy
go mod vendor

@bflad bflad added dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jan 16, 2019
@bflad bflad added this to the v2.0.0 milestone Jan 16, 2019
@bflad bflad requested a review from a team January 16, 2019 22:28
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 16, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bflad bflad force-pushed the f-go-modules branch 2 times, most recently from f28ecfa to 043cc34 Compare January 16, 2019 22:42
Remove govendor for dependency management and add service clients for new services we want to vendor.

```
go mod init
go mod tidy
go mod vendor
```
@bflad bflad merged commit 0fbbfda into master Jan 16, 2019
@bflad bflad deleted the f-go-modules branch January 16, 2019 23:07
bflad added a commit that referenced this pull request Jan 26, 2019
@bflad bflad modified the milestones: v2.0.0, v1.57.0 Feb 24, 2019
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants