Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: aws/[email protected] #7164

Conversation

sunilkumarmohanty
Copy link
Contributor

Updated via govendor fetch github.com/aws/aws-sdk-go/[email protected]

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jan 16, 2019
@bflad
Copy link
Contributor

bflad commented Jan 17, 2019

Hi @sunilkumarmohanty 👋 Thanks for submitting this! Just a heads up that we are switching over to Go modules in preparation for Terraform 0.12 development and testing: #7165

We still have some work to do on our end including:

  • Documenting the new dependency upgrade workflow
  • Unfreezing changes to go.mod/go.sum when Terraform 0.12 provider SDK updates are more stable and merged into master

It'll likely be a few days before this work settles down and didn't want you to spend additional time on these in the meantime. Sorry for the hassle!

@bflad
Copy link
Contributor

bflad commented Jan 25, 2019

Hi again @sunilkumarmohanty 👋

We're currently in a much more stable place at the moment and able to accept aws-sdk-go dependency updates again as the Terraform 0.12 updates (happening in a separate branch currently) are applying cleanly with any changes in aws-sdk-go. 🎉

So! We will need to get this written somewhere but the gist of the new process is (e.g. version 1.16.25):

go get github.com/aws/[email protected]
go mod tidy
go mod vendor

This example update can be seen here: #7331

Closing this pull request as it was superseded by #7197

Thanks for your continued work with the Terraform AWS provider!

@bflad bflad closed this Jan 25, 2019
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants