feature: Support SecretsManagerConfiguration for Firehose Delivery Stream Snowflake Configuration

[civitaspo]

Signed-off-by: Takahiro Nakayama [email protected]

Description

Amazon Data Firehose supports managing secrets using SecretsManager (SecretsManagerConfiguration). However, the terraform-provider-aws does not support the use of SecretsManagerConfiguration. Therefore, I have made it possible to use SecretsManagerConfiguration.

Since the implementation effort is significant, I have only implemented it within the SnowflakeConfiguration, which I need. If this implementation is accepted, it will be possible to incorporate SecretsManagerConfiguration into other configurations with separate Pull Requests.

Additionally, this change (cefe73a) is not the feature I wanted to add in this Pull Request, but I found a bug while writing tests, so I fixed it as well.

Relations

Closes #38210.
Closes #38245.
Relates #36646.

References

• SnowflakeDestinationConfiguration
• SecretsManagerConfiguration

Output from Acceptance Testing

% make testacc TESTS=TestAccFirehoseDeliveryStream_snowflake PKG=firehose
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/firehose/... -v -count 1 -parallel 20 -run='TestAccFirehoseDeliveryStream_snowflake'  -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_snowflakeUpdates
=== PAUSE TestAccFirehoseDeliveryStream_snowflakeUpdates
=== CONT  TestAccFirehoseDeliveryStream_snowflakeUpdates
--- PASS: TestAccFirehoseDeliveryStream_snowflakeUpdates (154.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/firehose   158.176s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @civitaspo 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[civitaspo]

Sorry. I intended to write the documentation after receiving a code review, without considering the maintainer's busy schedule. However, after reading the FAQ and understanding the maintainer's workload, I have also added the documentation. This Pull Request is review-ready, so I am awaiting your review.

[civitaspo]

This PR will conflict with #38245 because both make changes related to SecretsManagerConfiguration.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_Splunk\|TestAccFirehoseDeliveryStream_splunk\|TestAccFirehoseDeliveryStream_Redshift\|TestAccFirehoseDeliveryStream_redshift\|TestAccFirehoseDeliveryStream_HTTPEndpoint\|TestAccFirehoseDeliveryStream_httpEndpoint\|TestAccFirehoseDeliveryStream_snowflake' PKG=firehose ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/firehose/... -v -count 1 -parallel 3  -run=TestAccFirehoseDeliveryStream_Splunk\|TestAccFirehoseDeliveryStream_splunk\|TestAccFirehoseDeliveryStream_Redshift\|TestAccFirehoseDeliveryStream_redshift\|TestAccFirehoseDeliveryStream_HTTPEndpoint\|TestAccFirehoseDeliveryStream_httpEndpoint\|TestAccFirehoseDeliveryStream_snowflake -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_redshiftUpdates
=== PAUSE TestAccFirehoseDeliveryStream_redshiftUpdates
=== RUN   TestAccFirehoseDeliveryStream_Redshift_SecretsManagerConfiguration
=== PAUSE TestAccFirehoseDeliveryStream_Redshift_SecretsManagerConfiguration
=== RUN   TestAccFirehoseDeliveryStream_snowflakeUpdates
=== PAUSE TestAccFirehoseDeliveryStream_snowflakeUpdates
=== RUN   TestAccFirehoseDeliveryStream_splunkUpdates
=== PAUSE TestAccFirehoseDeliveryStream_splunkUpdates
=== RUN   TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_Splunk_SecretsManagerConfiguration
=== PAUSE TestAccFirehoseDeliveryStream_Splunk_SecretsManagerConfiguration
=== RUN   TestAccFirehoseDeliveryStream_httpEndpoint
=== PAUSE TestAccFirehoseDeliveryStream_httpEndpoint
=== RUN   TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration
=== PAUSE TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration
=== RUN   TestAccFirehoseDeliveryStream_HTTPEndpoint_SecretsManagerConfiguration
=== PAUSE TestAccFirehoseDeliveryStream_HTTPEndpoint_SecretsManagerConfiguration
=== CONT  TestAccFirehoseDeliveryStream_redshiftUpdates
=== CONT  TestAccFirehoseDeliveryStream_Splunk_SecretsManagerConfiguration
=== CONT  TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration
--- PASS: TestAccFirehoseDeliveryStream_Splunk_SecretsManagerConfiguration (71.24s)
=== CONT  TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration (71.46s)
=== CONT  TestAccFirehoseDeliveryStream_httpEndpoint
--- PASS: TestAccFirehoseDeliveryStream_httpEndpoint (82.28s)
=== CONT  TestAccFirehoseDeliveryStream_splunkUpdates
--- PASS: TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix (125.67s)
=== CONT  TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_splunkUpdates (107.60s)
=== CONT  TestAccFirehoseDeliveryStream_HTTPEndpoint_SecretsManagerConfiguration
--- PASS: TestAccFirehoseDeliveryStream_redshiftUpdates (262.53s)
=== CONT  TestAccFirehoseDeliveryStream_snowflakeUpdates
--- PASS: TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix (105.05s)
=== CONT  TestAccFirehoseDeliveryStream_Redshift_SecretsManagerConfiguration
--- PASS: TestAccFirehoseDeliveryStream_HTTPEndpoint_SecretsManagerConfiguration (82.61s)
--- PASS: TestAccFirehoseDeliveryStream_snowflakeUpdates (139.41s)
--- PASS: TestAccFirehoseDeliveryStream_Redshift_SecretsManagerConfiguration (245.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	555.888s

% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_basic' PKG=firehose
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/firehose/... -v -count 1 -parallel 20  -run=TestAccFirehoseDeliveryStream_basic -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_basic
=== PAUSE TestAccFirehoseDeliveryStream_basic
=== CONT  TestAccFirehoseDeliveryStream_basic
--- PASS: TestAccFirehoseDeliveryStream_basic (92.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	97.192s

[ewbankkit]

@civitaspo @nikhil-goenka Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[civitaspo]

Thank you for making the changes that allow the configuration of SecretsManagerConfiguration for all services, not just Snowflake ❤️

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.