-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: snowflake destination addition in firehose kinesis stream #36646
Enhancement: snowflake destination addition in firehose kinesis stream #36646
Conversation
Community NoteVoting for Prioritization
For Submitters
|
I have contributed first time in go lang and have a minimal knowledge of this language so any modifications or any additions are much appreciated . Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @mayank0202 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_snowflakeUpdates' PKG=firehose ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/firehose/... -v -count 1 -parallel 20 -run=TestAccFirehoseDeliveryStream_snowflakeUpdates -timeout 360m === RUN TestAccFirehoseDeliveryStream_snowflakeUpdates === PAUSE TestAccFirehoseDeliveryStream_snowflakeUpdates === CONT TestAccFirehoseDeliveryStream_snowflakeUpdates --- PASS: TestAccFirehoseDeliveryStream_snowflakeUpdates (102.16s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/firehose 114.313s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_snowflakeUpdates' PKG=firehose
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/firehose/... -v -count 1 -parallel 20 -run=TestAccFirehoseDeliveryStream_snowflakeUpdates -timeout 360m
=== RUN TestAccFirehoseDeliveryStream_snowflakeUpdates
=== PAUSE TestAccFirehoseDeliveryStream_snowflakeUpdates
=== CONT TestAccFirehoseDeliveryStream_snowflakeUpdates
--- PASS: TestAccFirehoseDeliveryStream_snowflakeUpdates (102.16s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/firehose 114.313s
% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_basic' PKG=firehose
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/firehose/... -v -count 1 -parallel 20 -run=TestAccFirehoseDeliveryStream_basic -timeout 360m
=== RUN TestAccFirehoseDeliveryStream_basic
=== PAUSE TestAccFirehoseDeliveryStream_basic
=== CONT TestAccFirehoseDeliveryStream_basic
--- PASS: TestAccFirehoseDeliveryStream_basic (80.27s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/firehose 92.235s
@mayank0202 Thanks for the contribution 🎉 👏. |
Thanks for the help @ewbankkit 💯 |
This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Addition of snowflake destination in firehose kinesis stream
Release notes for Kinesis Firehose direct to Snowflake streaming: https://aws.amazon.com/about-aws/whats-new/2024/01/stream-data-snowflake-kinesis-data-firehose-snowpipe-streaming-preview/
See the --snowflake-destination-configuration flag in the AWS CLI Docs here: https://docs.aws.amazon.com/cli/latest/reference/firehose/create-delivery-stream.html
Closes #35647.