resource/aws_config_configuration_recorder add retention period

[mtt88]

Description

Adds retention period to aws_config_configuration_recorder as per proposed solution and discussion on #13305

Some observations:

• There is no explicit relationship between a retention period and configuration recorder. However, the retention period is only
  used to control the retention of configuration captured under a configuration recorder.
• AWS only lets us create a single retention period and configuration recorder per region, so whilst an explicit relationship does not exist a relationship does exist by this virtue.
  • The AWS Console UI shows/groups the retention period under the other configuration recorder settings.
• After a retention configuration is created its given the name 'default'. It is not possible to change this name and all further
  interactions with the retention configuration resource require it to be referenced by this name attribute.

Are we happy adding retention period to the existing aws_config_configuration_recorder resource based on this behaviour? Please let me know if we would prefer to create this as a seperate resource and I can refactor this PR to reflect that.

Relations

Closes #13305

References

https://docs.aws.amazon.com/config/latest/APIReference/API_PutRetentionConfiguration.html
https://docs.aws.amazon.com/config/latest/APIReference/API_DeleteRetentionConfiguration.html
https://docs.aws.amazon.com/config/latest/APIReference/API_ConfigurationRecorder.html

https://docs.aws.amazon.com/config/latest/APIReference/API_RetentionConfiguration.html

Output from Acceptance Testing

 make testacc TESTS=TestAccConfigServiceConfigurationRecorder_allParams PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20 -run='TestAccConfigServiceConfigurationRecorder_allParams'  -timeout 180m
=== RUN   TestAccConfigServiceConfigurationRecorder_allParams
--- PASS: TestAccConfigServiceConfigurationRecorder_allParams (48.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/configservice      48.738s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[sherifkayad]

can we maybe get this one merged? looks like an easy win to me and already required by so many people who put a thumbs up on the issue #13305 (not the PR).

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.