Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

b/Config Service rule: Prevent duplication on name change #15136

Merged
merged 66 commits into from
Feb 27, 2024
Merged

b/Config Service rule: Prevent duplication on name change #15136

merged 66 commits into from
Feb 27, 2024

Conversation

FaHeymann
Copy link
Contributor

@FaHeymann FaHeymann commented Sep 13, 2020 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #4427.
Closes #29125.
Closes #33742.
Relates #32976.
Closes #25254.
Relates #27262.
Closes #13305.

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSConfig_serial'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSConfig_serial -timeout 120m
=== RUN   TestAccAWSConfig_serial
=== RUN   TestAccAWSConfig_serial/Config
=== RUN   TestAccAWSConfig_serial/Config/scopeTagValue
=== RUN   TestAccAWSConfig_serial/Config/basic
=== RUN   TestAccAWSConfig_serial/Config/customlambda
=== RUN   TestAccAWSConfig_serial/Config/scopeTagKey
=== RUN   TestAccAWSConfig_serial/Config/scopeTagKeyEmpty
=== RUN   TestAccAWSConfig_serial/Config/ownerAws
=== RUN   TestAccAWSConfig_serial/Config/importAws
=== RUN   TestAccAWSConfig_serial/Config/importLambda
=== RUN   TestAccAWSConfig_serial/Config/tags
=== RUN   TestAccAWSConfig_serial/ConfigurationRecorderStatus
=== RUN   TestAccAWSConfig_serial/ConfigurationRecorderStatus/importBasic
=== RUN   TestAccAWSConfig_serial/ConfigurationRecorderStatus/basic
=== RUN   TestAccAWSConfig_serial/ConfigurationRecorderStatus/startEnabled
=== RUN   TestAccAWSConfig_serial/ConfigurationRecorder
=== RUN   TestAccAWSConfig_serial/ConfigurationRecorder/basic
=== RUN   TestAccAWSConfig_serial/ConfigurationRecorder/allParams
=== RUN   TestAccAWSConfig_serial/ConfigurationRecorder/importBasic
=== RUN   TestAccAWSConfig_serial/DeliveryChannel
=== RUN   TestAccAWSConfig_serial/DeliveryChannel/importBasic
=== RUN   TestAccAWSConfig_serial/DeliveryChannel/basic
=== RUN   TestAccAWSConfig_serial/DeliveryChannel/allParams
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/InputParameters
    TestAccAWSConfig_serial/OrganizationCustomRule/InputParameters: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/ResourceIdScope
    TestAccAWSConfig_serial/OrganizationCustomRule/ResourceIdScope: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/ResourceTypesScope
    TestAccAWSConfig_serial/OrganizationCustomRule/ResourceTypesScope: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/TagKeyScope
    TestAccAWSConfig_serial/OrganizationCustomRule/TagKeyScope: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/TriggerTypes
    TestAccAWSConfig_serial/OrganizationCustomRule/TriggerTypes: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/Description
    TestAccAWSConfig_serial/OrganizationCustomRule/Description: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/ExcludedAccounts
    TestAccAWSConfig_serial/OrganizationCustomRule/ExcludedAccounts: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/errorHandling
    TestAccAWSConfig_serial/OrganizationCustomRule/errorHandling: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/LambdaFunctionArn
    TestAccAWSConfig_serial/OrganizationCustomRule/LambdaFunctionArn: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/MaximumExecutionFrequency
    TestAccAWSConfig_serial/OrganizationCustomRule/MaximumExecutionFrequency: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/TagValueScope
    TestAccAWSConfig_serial/OrganizationCustomRule/TagValueScope: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/basic
    TestAccAWSConfig_serial/OrganizationCustomRule/basic: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationCustomRule/disappears
    TestAccAWSConfig_serial/OrganizationCustomRule/disappears: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/TagKeyScope
    TestAccAWSConfig_serial/OrganizationManagedRule/TagKeyScope: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/disappears
    TestAccAWSConfig_serial/OrganizationManagedRule/disappears: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/Description
    TestAccAWSConfig_serial/OrganizationManagedRule/Description: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/InputParameters
    TestAccAWSConfig_serial/OrganizationManagedRule/InputParameters: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/ResourceIdScope
    TestAccAWSConfig_serial/OrganizationManagedRule/ResourceIdScope: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/RuleIdentifier
    TestAccAWSConfig_serial/OrganizationManagedRule/RuleIdentifier: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/TagValueScope
    TestAccAWSConfig_serial/OrganizationManagedRule/TagValueScope: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/basic
    TestAccAWSConfig_serial/OrganizationManagedRule/basic: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/errorHandling
    TestAccAWSConfig_serial/OrganizationManagedRule/errorHandling: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/ExcludedAccounts
    TestAccAWSConfig_serial/OrganizationManagedRule/ExcludedAccounts: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/MaximumExecutionFrequency
    TestAccAWSConfig_serial/OrganizationManagedRule/MaximumExecutionFrequency: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSConfig_serial/OrganizationManagedRule/ResourceTypesScope
    TestAccAWSConfig_serial/OrganizationManagedRule/ResourceTypesScope: provider_test.go:578: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- PASS: TestAccAWSConfig_serial (1185.79s)
    --- PASS: TestAccAWSConfig_serial/Config (856.85s)
        --- PASS: TestAccAWSConfig_serial/Config/scopeTagValue (92.35s)
        --- PASS: TestAccAWSConfig_serial/Config/basic (81.73s)
        --- PASS: TestAccAWSConfig_serial/Config/customlambda (120.91s)
        --- PASS: TestAccAWSConfig_serial/Config/scopeTagKey (91.18s)
        --- PASS: TestAccAWSConfig_serial/Config/scopeTagKeyEmpty (80.16s)
        --- PASS: TestAccAWSConfig_serial/Config/ownerAws (81.95s)
        --- PASS: TestAccAWSConfig_serial/Config/importAws (84.12s)
        --- PASS: TestAccAWSConfig_serial/Config/importLambda (116.33s)
        --- PASS: TestAccAWSConfig_serial/Config/tags (108.12s)
    --- PASS: TestAccAWSConfig_serial/ConfigurationRecorderStatus (107.78s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorderStatus/importBasic (28.90s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorderStatus/basic (27.00s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorderStatus/startEnabled (51.87s)
    --- PASS: TestAccAWSConfig_serial/ConfigurationRecorder (99.51s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorder/basic (35.83s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorder/allParams (27.13s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorder/importBasic (36.55s)
    --- PASS: TestAccAWSConfig_serial/DeliveryChannel (83.20s)
        --- PASS: TestAccAWSConfig_serial/DeliveryChannel/importBasic (28.91s)
        --- PASS: TestAccAWSConfig_serial/DeliveryChannel/basic (26.69s)
        --- PASS: TestAccAWSConfig_serial/DeliveryChannel/allParams (27.61s)
    --- PASS: TestAccAWSConfig_serial/OrganizationCustomRule (20.41s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/InputParameters (1.52s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/ResourceIdScope (1.76s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/ResourceTypesScope (2.85s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/TagKeyScope (1.71s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/TriggerTypes (1.40s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/Description (1.43s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/ExcludedAccounts (1.41s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/errorHandling (1.46s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/LambdaFunctionArn (1.43s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/MaximumExecutionFrequency (1.35s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/TagValueScope (1.36s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/basic (1.32s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/disappears (1.40s)
    --- PASS: TestAccAWSConfig_serial/OrganizationManagedRule (18.03s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/TagKeyScope (1.32s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/disappears (1.37s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/Description (1.66s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/InputParameters (2.01s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/ResourceIdScope (1.39s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/RuleIdentifier (1.38s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/TagValueScope (1.49s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/basic (1.39s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/errorHandling (1.39s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/ExcludedAccounts (1.36s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/MaximumExecutionFrequency (1.36s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/ResourceTypesScope (1.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1187.468s

@FaHeymann FaHeymann requested a review from a team September 13, 2020 09:42
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/configservice Issues and PRs that pertain to the configservice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 13, 2020
@FaHeymann FaHeymann force-pushed the prevent-duplicate-config-rules-on-name-change branch from a040716 to 8cdc3ef Compare September 13, 2020 10:29
Base automatically changed from master to main January 23, 2021 00:59
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:59
@breathingdust breathingdust added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@FaHeymann FaHeymann force-pushed the prevent-duplicate-config-rules-on-name-change branch from 8cdc3ef to 09d492d Compare October 20, 2021 17:59
@github-actions github-actions bot removed the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Oct 20, 2021
@jbscare jbscare mentioned this pull request Jan 7, 2022
Closed
@FaHeymann FaHeymann force-pushed the prevent-duplicate-config-rules-on-name-change branch from 09d492d to 041e73c Compare January 15, 2022 18:27
@github-actions GitHub Actions
Copy link

Marking this pull request as stale due to inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Feb 19, 2024
@ewbankkit
Revert "Config Service rule: Prevent duplication on name change"
c899095 
This reverts commit 041e73c.
@ewbankkit
Merge branch 'main' into HEAD
1c6c263
@ewbankkit
configservice: Use AWS SDK for Go v2.
320729d
@ewbankkit
Run 'make gen'.
aa1b485
@ewbankkit
Run 'go get github.com/aws/aws-sdk-go-v2/service/[email protected].…
e644e55 
…2 && go mod tidy'.
@ewbankkit
r/aws_config_configuration_recorder: Migrate to AWS SDK for Go v2.
a06a14d
@ewbankkit
Add CHANGELOG entry.
b9a7478
@ewbankkit
r/aws_config_configuration_recorder_status: Migrate to AWS SDK for Go…
886c01b 
… v2.
@ewbankkit
r/aws_config_delivery_channel: Migrate to AWS SDK for Go v2.
f167a3b
@ewbankkit
r/aws_config_conformance_pack: Migrate to AWS SDK for Go v2.
4cdc96e
@ewbankkit
r/aws_config_aggregate_authorization: Migrate to AWS SDK for Go v2.
a87dde8
@ewbankkit
r/aws_config_configuration_aggregator: Migrate to AWS SDK for Go v2.
c884140
@ewbankkit
Acceptance test output:
1c452eb 
% make testacc TESTARGS='-run=TestAccConfigServiceAggregateAuthorization_' PKG=configservice ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 2  -run=TestAccConfigServiceAggregateAuthorization_ -timeout 360m
=== RUN   TestAccConfigServiceAggregateAuthorization_basic
=== PAUSE TestAccConfigServiceAggregateAuthorization_basic
=== RUN   TestAccConfigServiceAggregateAuthorization_disappears
=== PAUSE TestAccConfigServiceAggregateAuthorization_disappears
=== RUN   TestAccConfigServiceAggregateAuthorization_tags
=== PAUSE TestAccConfigServiceAggregateAuthorization_tags
=== CONT  TestAccConfigServiceAggregateAuthorization_basic
=== CONT  TestAccConfigServiceAggregateAuthorization_tags
--- PASS: TestAccConfigServiceAggregateAuthorization_basic (22.53s)
=== CONT  TestAccConfigServiceAggregateAuthorization_disappears
--- PASS: TestAccConfigServiceAggregateAuthorization_disappears (16.91s)
--- PASS: TestAccConfigServiceAggregateAuthorization_tags (47.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	59.457s
@ewbankkit
r/aws_config_aggregate_authorization: Tweak acceptance tests.
dca9617
@ewbankkit
Fix golangci-lint 'whitespace'.
ea8fc65
@ewbankkit
Fix golangci-lint 'unparam'.
ba41d3b
@ewbankkit
r/aws_config_retention_configuration: New resource.
143552f
@ewbankkit
Correct 'testAccCheckRemediationConfigurationDestroy'.
1c41529
@ewbankkit
Acceptance test output:
7813f69 
% make testacc TESTARGS='-run=TestAccConfigService_serial/RemediationConfiguration/disappears' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/RemediationConfiguration/disappears -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/RemediationConfiguration
=== RUN   TestAccConfigService_serial/RemediationConfiguration/disappears
--- PASS: TestAccConfigService_serial (100.07s)
    --- PASS: TestAccConfigService_serial/RemediationConfiguration (100.06s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/disappears (100.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	111.860s
@ewbankkit
r/aws_config_retention_configuration: Add acceptance tests.
45ad658
@ewbankkit
Add 'context.Context' to 'acctest.(Parallel)Test'.
9e190f3
@ewbankkit
Add 'context.Context' to 'acctest.ProviderMeta'.
288fc8c
@ewbankkit
r/aws_config_rule: Fix `InvalidParameterValueException: PolicyText is…
558edba 
… required when Owner is CUSTOM_POLICY` errors on resource Update.
@ewbankkit
Acceptance test output:
159e45d 
% make testacc TESTARGS='-run=TestAccConfigService_serial/ConfigRule' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/ConfigRule -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/ConfigRule
=== RUN   TestAccConfigService_serial/ConfigRule/basic
=== RUN   TestAccConfigService_serial/ConfigRule/disappears
=== RUN   TestAccConfigService_serial/ConfigRule/evaluationMode
=== RUN   TestAccConfigService_serial/ConfigRule/scopeTagKey
=== RUN   TestAccConfigService_serial/ConfigRule/scopeTagKeyEmpty
=== RUN   TestAccConfigService_serial/ConfigRule/scopeTagValue
=== RUN   TestAccConfigService_serial/ConfigRule/tags
=== RUN   TestAccConfigService_serial/ConfigRule/ownerAws
=== RUN   TestAccConfigService_serial/ConfigRule/customlambda
=== RUN   TestAccConfigService_serial/ConfigRule/customPolicy
--- PASS: TestAccConfigService_serial (1055.80s)
    --- PASS: TestAccConfigService_serial/ConfigRule (1055.79s)
        --- PASS: TestAccConfigService_serial/ConfigRule/basic (97.99s)
        --- PASS: TestAccConfigService_serial/ConfigRule/disappears (97.10s)
        --- PASS: TestAccConfigService_serial/ConfigRule/evaluationMode (108.91s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagKey (109.03s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagKeyEmpty (96.78s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagValue (108.59s)
        --- PASS: TestAccConfigService_serial/ConfigRule/tags (125.16s)
        --- PASS: TestAccConfigService_serial/ConfigRule/ownerAws (100.72s)
        --- PASS: TestAccConfigService_serial/ConfigRule/customlambda (126.20s)
        --- PASS: TestAccConfigService_serial/ConfigRule/customPolicy (114.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	1067.334s
@ewbankkit
r/aws_config_configuration_aggregator: No need to call 'PutConfigurat…
a37622a 
…ionAggregator' if only 'tags' change.
@ewbankkit
Acceptance test output:
1a2b956 
% make testacc TESTARGS='-run=TestAccConfigServiceConfigurationAggregator_' PKG=configservice ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 2  -run=TestAccConfigServiceConfigurationAggregator_ -timeout 360m
=== RUN   TestAccConfigServiceConfigurationAggregator_account
=== PAUSE TestAccConfigServiceConfigurationAggregator_account
=== RUN   TestAccConfigServiceConfigurationAggregator_organization
    configuration_aggregator_test.go:66: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccConfigServiceConfigurationAggregator_organization (0.61s)
=== RUN   TestAccConfigServiceConfigurationAggregator_switch
    configuration_aggregator_test.go:96: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccConfigServiceConfigurationAggregator_switch (0.12s)
=== RUN   TestAccConfigServiceConfigurationAggregator_tags
=== PAUSE TestAccConfigServiceConfigurationAggregator_tags
=== RUN   TestAccConfigServiceConfigurationAggregator_disappears
=== PAUSE TestAccConfigServiceConfigurationAggregator_disappears
=== CONT  TestAccConfigServiceConfigurationAggregator_account
=== CONT  TestAccConfigServiceConfigurationAggregator_disappears
--- PASS: TestAccConfigServiceConfigurationAggregator_disappears (17.13s)
=== CONT  TestAccConfigServiceConfigurationAggregator_tags
--- PASS: TestAccConfigServiceConfigurationAggregator_account (20.29s)
--- PASS: TestAccConfigServiceConfigurationAggregator_tags (41.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	70.217s
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/lambda Issues and PRs that pertain to the lambda service. service/logs Issues and PRs that pertain to the logs service. service/scheduler Issues and PRs that pertain to the scheduler service. labels Feb 27, 2024
@ewbankkit ewbankkit mentioned this pull request Feb 27, 2024
Closed
ewbankkit
ewbankkit approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccConfigServiceConfigurationAggregator_' PKG=configservice ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 2  -run=TestAccConfigServiceConfigurationAggregator_ -timeout 360m
=== RUN   TestAccConfigServiceConfigurationAggregator_account
=== PAUSE TestAccConfigServiceConfigurationAggregator_account
=== RUN   TestAccConfigServiceConfigurationAggregator_organization
    configuration_aggregator_test.go:66: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccConfigServiceConfigurationAggregator_organization (0.63s)
=== RUN   TestAccConfigServiceConfigurationAggregator_switch
    configuration_aggregator_test.go:96: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccConfigServiceConfigurationAggregator_switch (0.12s)
=== RUN   TestAccConfigServiceConfigurationAggregator_tags
=== PAUSE TestAccConfigServiceConfigurationAggregator_tags
=== RUN   TestAccConfigServiceConfigurationAggregator_disappears
=== PAUSE TestAccConfigServiceConfigurationAggregator_disappears
=== CONT  TestAccConfigServiceConfigurationAggregator_account
=== CONT  TestAccConfigServiceConfigurationAggregator_disappears
--- PASS: TestAccConfigServiceConfigurationAggregator_disappears (19.02s)
=== CONT  TestAccConfigServiceConfigurationAggregator_tags
--- PASS: TestAccConfigServiceConfigurationAggregator_account (22.06s)
--- PASS: TestAccConfigServiceConfigurationAggregator_tags (41.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	71.904s
% make testacc TESTARGS='-run=TestAccConfigServiceConfigurationAggregator_' PKG=configservice ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 2  -run=TestAccConfigServiceConfigurationAggregator_ -timeout 360m
=== RUN   TestAccConfigServiceConfigurationAggregator_account
=== PAUSE TestAccConfigServiceConfigurationAggregator_account
=== RUN   TestAccConfigServiceConfigurationAggregator_organization
--- PASS: TestAccConfigServiceConfigurationAggregator_organization (23.17s)
=== RUN   TestAccConfigServiceConfigurationAggregator_switch
--- PASS: TestAccConfigServiceConfigurationAggregator_switch (30.48s)
=== RUN   TestAccConfigServiceConfigurationAggregator_tags
=== PAUSE TestAccConfigServiceConfigurationAggregator_tags
=== RUN   TestAccConfigServiceConfigurationAggregator_disappears
=== PAUSE TestAccConfigServiceConfigurationAggregator_disappears
=== CONT  TestAccConfigServiceConfigurationAggregator_account
=== CONT  TestAccConfigServiceConfigurationAggregator_disappears
--- PASS: TestAccConfigServiceConfigurationAggregator_disappears (16.96s)
=== CONT  TestAccConfigServiceConfigurationAggregator_tags
--- PASS: TestAccConfigServiceConfigurationAggregator_account (20.13s)
--- PASS: TestAccConfigServiceConfigurationAggregator_tags (41.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	123.489s
% make testacc TESTARGS='-run=TestAccConfigService_serial/ConfigurationRecorder$$' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/ConfigurationRecorder$ -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/ConfigurationRecorder
=== RUN   TestAccConfigService_serial/ConfigurationRecorder/recordStrategy
=== RUN   TestAccConfigService_serial/ConfigurationRecorder/disappears
=== RUN   TestAccConfigService_serial/ConfigurationRecorder/basic
=== RUN   TestAccConfigService_serial/ConfigurationRecorder/allParams
--- PASS: TestAccConfigService_serial (114.01s)
    --- PASS: TestAccConfigService_serial/ConfigurationRecorder (114.01s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorder/recordStrategy (31.34s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorder/disappears (26.35s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorder/basic (29.31s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorder/allParams (27.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	125.147s
% make testacc TESTARGS='-run=TestAccConfigService_serial/ConfigurationRecorderStatus' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/ConfigurationRecorderStatus -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/ConfigurationRecorderStatus
=== RUN   TestAccConfigService_serial/ConfigurationRecorderStatus/basic
=== RUN   TestAccConfigService_serial/ConfigurationRecorderStatus/startEnabled
=== RUN   TestAccConfigService_serial/ConfigurationRecorderStatus/disappears
--- PASS: TestAccConfigService_serial (129.79s)
    --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus (129.79s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus/basic (33.69s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus/startEnabled (66.67s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus/disappears (29.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	142.061s
% make testacc TESTARGS='-run=TestAccConfigService_serial/DeliveryChannel' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/DeliveryChannel -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/DeliveryChannel
=== RUN   TestAccConfigService_serial/DeliveryChannel/basic
=== RUN   TestAccConfigService_serial/DeliveryChannel/allParams
=== RUN   TestAccConfigService_serial/DeliveryChannel/disappears
--- PASS: TestAccConfigService_serial (99.44s)
    --- PASS: TestAccConfigService_serial/DeliveryChannel (99.44s)
        --- PASS: TestAccConfigService_serial/DeliveryChannel/basic (33.70s)
        --- PASS: TestAccConfigService_serial/DeliveryChannel/allParams (33.47s)
        --- PASS: TestAccConfigService_serial/DeliveryChannel/disappears (32.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	111.785s
% make testacc TESTARGS='-run=TestAccConfigService_serial/ConfigRule' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/ConfigRule -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/ConfigRule
=== RUN   TestAccConfigService_serial/ConfigRule/basic
=== RUN   TestAccConfigService_serial/ConfigRule/scopeTagKey
=== RUN   TestAccConfigService_serial/ConfigRule/customPolicy
=== RUN   TestAccConfigService_serial/ConfigRule/evaluationMode
=== RUN   TestAccConfigService_serial/ConfigRule/scopeTagKeyEmpty
=== RUN   TestAccConfigService_serial/ConfigRule/scopeTagValue
=== RUN   TestAccConfigService_serial/ConfigRule/tags
=== RUN   TestAccConfigService_serial/ConfigRule/disappears
=== RUN   TestAccConfigService_serial/ConfigRule/ownerAws
=== RUN   TestAccConfigService_serial/ConfigRule/customlambda
--- PASS: TestAccConfigService_serial (900.03s)
    --- PASS: TestAccConfigService_serial/ConfigRule (900.03s)
        --- PASS: TestAccConfigService_serial/ConfigRule/basic (89.92s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagKey (95.49s)
        --- PASS: TestAccConfigService_serial/ConfigRule/customPolicy (85.74s)
        --- PASS: TestAccConfigService_serial/ConfigRule/evaluationMode (100.03s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagKeyEmpty (87.22s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagValue (122.96s)
        --- PASS: TestAccConfigService_serial/ConfigRule/tags (150.29s)
        --- PASS: TestAccConfigService_serial/ConfigRule/disappears (82.47s)
        --- PASS: TestAccConfigService_serial/ConfigRule/ownerAws (84.96s)
        --- PASS: TestAccConfigService_serial/ConfigRule/customlambda (114.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	914.018s
% make testacc TESTARGS='-run=TestAccConfigService_serial/ConformancePack' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/ConformancePack -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/ConformancePack
=== RUN   TestAccConfigService_serial/ConformancePack/inputParameters
=== RUN   TestAccConfigService_serial/ConformancePack/S3Template
=== RUN   TestAccConfigService_serial/ConformancePack/S3TemplateAndTemplateBody
=== RUN   TestAccConfigService_serial/ConformancePack/updateInputParameters
=== RUN   TestAccConfigService_serial/ConformancePack/updateS3Template
=== RUN   TestAccConfigService_serial/ConformancePack/updateTemplateBody
=== RUN   TestAccConfigService_serial/ConformancePack/basic
=== RUN   TestAccConfigService_serial/ConformancePack/disappears
=== RUN   TestAccConfigService_serial/ConformancePack/updateName
=== RUN   TestAccConfigService_serial/ConformancePack/S3Delivery
=== RUN   TestAccConfigService_serial/ConformancePack/updateS3Delivery
=== RUN   TestAccConfigService_serial/OrganizationConformancePack
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/updateS3Template
    organization_conformance_pack_test.go:374: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/basic
    organization_conformance_pack_test.go:33: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/disappears
    organization_conformance_pack_test.go:67: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/excludedAccounts
    organization_conformance_pack_test.go:91: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/inputParameters
    organization_conformance_pack_test.go:185: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/S3Delivery
    organization_conformance_pack_test.go:219: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/S3Template
    organization_conformance_pack_test.go:249: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/updateName
    organization_conformance_pack_test.go:141: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/updateInputParameters
    organization_conformance_pack_test.go:283: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/updateS3Delivery
    organization_conformance_pack_test.go:335: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/updateTemplateBody
    organization_conformance_pack_test.go:408: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- PASS: TestAccConfigService_serial (1855.69s)
    --- PASS: TestAccConfigService_serial/ConformancePack (1845.72s)
        --- PASS: TestAccConfigService_serial/ConformancePack/inputParameters (125.05s)
        --- PASS: TestAccConfigService_serial/ConformancePack/S3Template (125.21s)
        --- PASS: TestAccConfigService_serial/ConformancePack/S3TemplateAndTemplateBody (126.99s)
        --- PASS: TestAccConfigService_serial/ConformancePack/updateInputParameters (195.13s)
        --- PASS: TestAccConfigService_serial/ConformancePack/updateS3Template (167.60s)
        --- PASS: TestAccConfigService_serial/ConformancePack/updateTemplateBody (313.65s)
        --- PASS: TestAccConfigService_serial/ConformancePack/basic (120.07s)
        --- PASS: TestAccConfigService_serial/ConformancePack/disappears (118.02s)
        --- PASS: TestAccConfigService_serial/ConformancePack/updateName (245.06s)
        --- PASS: TestAccConfigService_serial/ConformancePack/S3Delivery (122.30s)
        --- PASS: TestAccConfigService_serial/ConformancePack/updateS3Delivery (186.63s)
    --- PASS: TestAccConfigService_serial/OrganizationConformancePack (9.97s)
        --- SKIP: TestAccConfigService_serial/OrganizationConformancePack/updateS3Template (0.22s)
        --- SKIP: TestAccConfigService_serial/OrganizationConformancePack/basic (0.12s)
        --- SKIP: TestAccConfigService_serial/OrganizationConformancePack/disappears (2.74s)
        --- SKIP: TestAccConfigService_serial/OrganizationConformancePack/excludedAccounts (0.11s)
        --- SKIP: TestAccConfigService_serial/OrganizationConformancePack/inputParameters (1.05s)
        --- SKIP: TestAccConfigService_serial/OrganizationConformancePack/S3Delivery (0.77s)
        --- SKIP: TestAccConfigService_serial/OrganizationConformancePack/S3Template (1.17s)
        --- SKIP: TestAccConfigService_serial/OrganizationConformancePack/updateName (2.56s)
        --- SKIP: TestAccConfigService_serial/OrganizationConformancePack/updateInputParameters (0.11s)
        --- SKIP: TestAccConfigService_serial/OrganizationConformancePack/updateS3Delivery (0.99s)
        --- SKIP: TestAccConfigService_serial/OrganizationConformancePack/updateTemplateBody (0.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	1867.942s
% make testacc TESTARGS='-run=TestAccConfigService_serial/RemediationConfiguration' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/RemediationConfiguration -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/RemediationConfiguration
=== RUN   TestAccConfigService_serial/RemediationConfiguration/disappears        
=== RUN   TestAccConfigService_serial/RemediationConfiguration/updates
=== RUN   TestAccConfigService_serial/RemediationConfiguration/values
=== RUN   TestAccConfigService_serial/RemediationConfiguration/basic
=== RUN   TestAccConfigService_serial/RemediationConfiguration/basicBackward
--- PASS: TestAccConfigService_serial (458.89s)
    --- PASS: TestAccConfigService_serial/RemediationConfiguration (458.89s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/disappears (85.68s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/updates (98.01s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/values (86.77s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/basic (87.75s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/basicBackward (86.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	469.902s
% make testacc TESTARGS='-run=TestAccConfigService_serial/OrganizationCustomRule$$' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/OrganizationCustomRule$ -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/OrganizationCustomRule
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/LambdaFunctionArn
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/TriggerTypes
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/basic
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/errorHandling
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/InputParameters
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/ExcludedAccounts
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/TagKeyScope
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/TagValueScope
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/MaximumExecutionFrequency
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/ResourceTypesScope
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/disappears
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/Description
=== RUN   TestAccConfigService_serial/OrganizationCustomRule/ResourceIdScope
--- PASS: TestAccConfigService_serial (3645.06s)
    --- PASS: TestAccConfigService_serial/OrganizationCustomRule (3645.06s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/LambdaFunctionArn (307.46s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/TriggerTypes (326.86s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/basic (227.41s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/errorHandling (269.43s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/InputParameters (343.14s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/ExcludedAccounts (389.54s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/TagKeyScope (364.42s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/TagValueScope (308.11s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/MaximumExecutionFrequency (330.23s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/ResourceTypesScope (312.46s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/disappears (237.44s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/Description (326.96s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomRule/ResourceIdScope (308.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	3659.078s
% make testacc TESTARGS='-run=TestAccConfigService_serial/OrganizationCustomPolicyRule' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/OrganizationCustomPolicyRule -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/OrganizationCustomPolicyRule
=== RUN   TestAccConfigService_serial/OrganizationCustomPolicyRule/basic
=== RUN   TestAccConfigService_serial/OrganizationCustomPolicyRule/disappears
=== RUN   TestAccConfigService_serial/OrganizationCustomPolicyRule/policyText
--- PASS: TestAccConfigService_serial (563.54s)
    --- PASS: TestAccConfigService_serial/OrganizationCustomPolicyRule (563.54s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomPolicyRule/basic (270.93s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomPolicyRule/disappears (193.41s)
        --- PASS: TestAccConfigService_serial/OrganizationCustomPolicyRule/policyText (274.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	575.052s
% make testacc TESTARGS='-run=TestAccConfigService_serial/OrganizationConformancePack' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/OrganizationConformancePack -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/OrganizationConformancePack
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/disappears
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/excludedAccounts
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/inputParameters
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/updateInputParameters
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/updateS3Delivery
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/updateTemplateBody        
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/basic
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/updateName        
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/S3Delivery
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/S3Template
=== RUN   TestAccConfigService_serial/OrganizationConformancePack/updateS3Template
--- PASS: TestAccConfigService_serial (4422.46s)
    --- PASS: TestAccConfigService_serial/OrganizationConformancePack (4422.46s)
        --- PASS: TestAccConfigService_serial/OrganizationConformancePack/disappears (414.82s)
        --- PASS: TestAccConfigService_serial/OrganizationConformancePack/excludedAccounts (770.43s)
        --- PASS: TestAccConfigService_serial/OrganizationConformancePack/inputParameters (414.49s)
        --- PASS: TestAccConfigService_serial/OrganizationConformancePack/updateInputParameters (743.49s)
        --- PASS: TestAccConfigService_serial/OrganizationConformancePack/updateS3Delivery (588.02s)
        --- PASS: TestAccConfigService_serial/OrganizationConformancePack/updateTemplateBody (722.41s)
        --- PASS: TestAccConfigService_serial/OrganizationConformancePack/basic (431.27s)
        --- PASS: TestAccConfigService_serial/OrganizationConformancePack/updateName (886.44s)
        --- PASS: TestAccConfigService_serial/OrganizationConformancePack/S3Delivery (453.69s)
        --- PASS: TestAccConfigService_serial/OrganizationConformancePack/S3Template (452.99s)
        --- PASS: TestAccConfigService_serial/OrganizationConformancePack/updateS3Template (656.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	4433.701s
% make testacc TESTARGS='-run=TestAccConfigService_serial/OrganizationManagedRule' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/OrganizationManagedRule -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/OrganizationManagedRule
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/ResourceIdScope
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/ResourceTypesScope
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/TagKeyScope
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/TagValueScope
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/disappears
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/ExcludedAccounts
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/MaximumExecutionFrequency
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/InputParameters
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/RuleIdentifier
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/basic
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/errorHandling
=== RUN   TestAccConfigService_serial/OrganizationManagedRule/Description
--- PASS: TestAccConfigService_serial (2055.53s)
    --- PASS: TestAccConfigService_serial/OrganizationManagedRule (2055.53s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/ResourceIdScope (308.59s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/ResourceTypesScope (294.03s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/TagKeyScope (326.27s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/TagValueScope (330.77s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/disappears (222.88s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/ExcludedAccounts (329.42s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/MaximumExecutionFrequency (303.68s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/InputParameters (290.47s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/RuleIdentifier (305.01s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/basic (241.67s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/errorHandling (201.80s)
        --- PASS: TestAccConfigService_serial/OrganizationManagedRule/Description (301.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	2069.318s
% make testacc TESTARGS='-run=TestAccConfigServiceAggregateAuthorization_' PKG=configservice ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 2  -run=TestAccConfigServiceAggregateAuthorization_ -timeout 360m
=== RUN   TestAccConfigServiceAggregateAuthorization_basic
=== PAUSE TestAccConfigServiceAggregateAuthorization_basic
=== RUN   TestAccConfigServiceAggregateAuthorization_disappears
=== PAUSE TestAccConfigServiceAggregateAuthorization_disappears
=== RUN   TestAccConfigServiceAggregateAuthorization_tags
=== PAUSE TestAccConfigServiceAggregateAuthorization_tags
=== CONT  TestAccConfigServiceAggregateAuthorization_basic
=== CONT  TestAccConfigServiceAggregateAuthorization_tags
--- PASS: TestAccConfigServiceAggregateAuthorization_basic (22.53s)
=== CONT  TestAccConfigServiceAggregateAuthorization_disappears
--- PASS: TestAccConfigServiceAggregateAuthorization_disappears (16.91s)
--- PASS: TestAccConfigServiceAggregateAuthorization_tags (47.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	59.457s
% make testacc TESTARGS='-run=TestAccConfigService_serial/RetentionConfiguration/basic' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/RetentionConfiguration/basic -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/RetentionConfiguration
=== RUN   TestAccConfigService_serial/RetentionConfiguration/basic
--- PASS: TestAccConfigService_serial (44.48s)
    --- PASS: TestAccConfigService_serial/RetentionConfiguration (44.48s)
        --- PASS: TestAccConfigService_serial/RetentionConfiguration/basic (44.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	55.435s
% make testacc TESTARGS='-run=TestAccConfigService_serial/RetentionConfiguration/disappears' PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/RetentionConfiguration/disappears -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/RetentionConfiguration
=== RUN   TestAccConfigService_serial/RetentionConfiguration/disappears
--- PASS: TestAccConfigService_serial (30.70s)
    --- PASS: TestAccConfigService_serial/RetentionConfiguration (30.70s)
        --- PASS: TestAccConfigService_serial/RetentionConfiguration/disappears (30.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	41.581s

@ewbankkit
Copy link
Contributor

@FaHeymann Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e8e0ab7 into hashicorp:main Feb 27, 2024
50 checks passed
@github-actions github-actions bot added this to the v5.39.0 milestone Feb 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/configservice Issues and PRs that pertain to the configservice service. service/lambda Issues and PRs that pertain to the lambda service. service/logs Issues and PRs that pertain to the logs service. service/organizations Issues and PRs that pertain to the organizations service. service/scheduler Issues and PRs that pertain to the scheduler service. service/shield Issues and PRs that pertain to the shield service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. service/sts Issues and PRs that pertain to the sts service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.39.0
4 participants
@FaHeymann @zhelding @ewbankkit @breathingdust