Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import test refactor for athena named queries #10609

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Import test refactor for athena named queries #10609

merged 1 commit into from
Oct 29, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSAthenaNamedQuery_"            ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSAthenaNamedQuery_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAthenaNamedQuery_basic
=== PAUSE TestAccAWSAthenaNamedQuery_basic
=== RUN   TestAccAWSAthenaNamedQuery_withWorkGroup
=== PAUSE TestAccAWSAthenaNamedQuery_withWorkGroup
=== CONT  TestAccAWSAthenaNamedQuery_basic
=== CONT  TestAccAWSAthenaNamedQuery_withWorkGroup
--- PASS: TestAccAWSAthenaNamedQuery_withWorkGroup (97.48s)
--- PASS: TestAccAWSAthenaNamedQuery_basic (97.58s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       99.021s

@ryndaniels ryndaniels requested review from bflad and a team October 23, 2019 13:37
@ghost ghost added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 23, 2019
nywilken
nywilken approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

--- PASS: TestAccAWSAthenaNamedQuery_basic (58.48s)
--- PASS: TestAccAWSAthenaNamedQuery_withWorkGroup (58.49s)

@bflad bflad added the service/athena Issues and PRs that pertain to the athena service. label Oct 28, 2019
@bflad bflad added this to the v2.34.0 milestone Oct 28, 2019
@ryndaniels ryndaniels merged commit f25ba8e into master Oct 29, 2019
@ryndaniels ryndaniels deleted the rfd-at002-athena branch October 29, 2019 09:20
bflad added a commit that referenced this pull request Nov 4, 2019
@bflad
provider: Fix hashibot pull request labeling for athena
b6ca863 
Reference: #10609
bflad added a commit that referenced this pull request Nov 4, 2019
@bflad
Various hashibot labeling fixes/additions (#10732)
f5b1da3 
* provider: Hashibot issue/PR matching for CloudTrail should not include trailing underscore

Reference: #10730

The CloudTrail Trail resource is named just `aws_cloudtrail`.

* provider: Hashibot pull request labeling for route53resolver should include underscore

Reference: #10348

* provider: Add missing pull request labeling for qldb

Reference: #10394

* provider: Fix hashibot pull request labeling for athena

Reference: #10609

* provider: Ensure hashibot labeling for apigateway catches aws_api_gateway_vpc_link

Reference: #10561
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

@bflad bflad Awaiting requested review from bflad

Assignees
No one assigned
Labels
service/athena Issues and PRs that pertain to the athena service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ryndaniels @nywilken @bflad