-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_route53_resolver_rule: Don't retrieve tags for rules 'SHARED_WITH_ME' #10348
Conversation
e3bc7cf
to
9f98b6d
Compare
$ AWS_ALTERNATE_ACCESS_KEY_ID=AAAAAAAAAAAAAAAAAAAA AWS_ALTERNATE_SECRET_ACCESS_KEY=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsRoute53ResolverRule__Shared'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 1 -run=TestAccDataSourceAwsRoute53ResolverRule_Shared -timeout 120m
=== RUN TestAccDataSourceAwsRoute53ResolverRule_SharedByMe
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_SharedByMe
=== RUN TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe
=== CONT TestAccDataSourceAwsRoute53ResolverRule_SharedByMe
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (224.69s)
=== CONT TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (327.07s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 551.873s Requires that the 2 accounts are in the same AWS Organization and that RAM Sharing with AWS Organizations is enabled. |
Ended up using the same pattern as in data "aws_organizations_organization" "test" {}
resource "aws_ram_principal_association" "test" {
principal = "${data.aws_organizations_organization.test.arn}"
resource_share_arn = "${aws_ram_resource_share.test.arn}"
} |
any timeline on when is this gonna be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for the fix and additional testing, @ewbankkit 🚀
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (29.29s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (194.42s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (192.54s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (7.87s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (185.97s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (193.63s)
…nclude underscore Reference: #10348
* provider: Hashibot issue/PR matching for CloudTrail should not include trailing underscore Reference: #10730 The CloudTrail Trail resource is named just `aws_cloudtrail`. * provider: Hashibot pull request labeling for route53resolver should include underscore Reference: #10348 * provider: Add missing pull request labeling for qldb Reference: #10394 * provider: Fix hashibot pull request labeling for athena Reference: #10609 * provider: Ensure hashibot labeling for apigateway catches aws_api_gateway_vpc_link Reference: #10561
This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #10211
Release note for CHANGELOG:
Output from acceptance testing: