-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make EKS access entry user_name and type configurable #35391
make EKS access entry user_name and type configurable #35391
Conversation
Community NoteVoting for Prioritization
For Submitters
|
de0a269
to
02a8ad8
Compare
02a8ad8
to
7fe8e03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEKSAccessEntry_username\|TestAccEKSAccessEntry_basic\|TestAccEKSAccessEntry_type' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run=TestAccEKSAccessEntry_username\|TestAccEKSAccessEntry_basic\|TestAccEKSAccessEntry_type -timeout 360m
=== RUN TestAccEKSAccessEntry_basic
=== PAUSE TestAccEKSAccessEntry_basic
=== RUN TestAccEKSAccessEntry_type
=== PAUSE TestAccEKSAccessEntry_type
=== RUN TestAccEKSAccessEntry_username
=== PAUSE TestAccEKSAccessEntry_username
=== CONT TestAccEKSAccessEntry_basic
=== CONT TestAccEKSAccessEntry_username
=== CONT TestAccEKSAccessEntry_type
--- PASS: TestAccEKSAccessEntry_basic (547.95s)
--- PASS: TestAccEKSAccessEntry_type (539.67s)
--- PASS: TestAccEKSAccessEntry_username (620.27s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 630.416s
@AndrewChubatiuk Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
currently
type
anduser_name
properties ofaws_eks_access_entry
, which makes it impossible to utilize this resource for nodes. fixed itRelates #35037.