-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_route53_resolver_endpoint
: add protocols
#35098
r/aws_route53_resolver_endpoint
: add protocols
#35098
Conversation
Community NoteVoting for Prioritization
For Submitters
|
aws_route53_resolver_endpoint
: add protocols
r/aws_route53_resolver_endpoint
: add protocols
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @aristosvo 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
r/aws_route53_resolver_endpoint
: add protocols
r/aws_route53_resolver_endpoint
: add protocols
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRoute53ResolverEndpointDataSource_\|TestAccRoute53ResolverEndpoint_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2 -run=TestAccRoute53ResolverEndpointDataSource_\|TestAccRoute53ResolverEndpoint_ -timeout 360m
=== RUN TestAccRoute53ResolverEndpointDataSource_basic
=== PAUSE TestAccRoute53ResolverEndpointDataSource_basic
=== RUN TestAccRoute53ResolverEndpointDataSource_filter
=== PAUSE TestAccRoute53ResolverEndpointDataSource_filter
=== RUN TestAccRoute53ResolverEndpoint_basic
=== PAUSE TestAccRoute53ResolverEndpoint_basic
=== RUN TestAccRoute53ResolverEndpoint_disappears
=== PAUSE TestAccRoute53ResolverEndpoint_disappears
=== RUN TestAccRoute53ResolverEndpoint_tags
=== PAUSE TestAccRoute53ResolverEndpoint_tags
=== RUN TestAccRoute53ResolverEndpoint_updateOutbound
=== PAUSE TestAccRoute53ResolverEndpoint_updateOutbound
=== CONT TestAccRoute53ResolverEndpointDataSource_basic
=== CONT TestAccRoute53ResolverEndpoint_disappears
--- PASS: TestAccRoute53ResolverEndpointDataSource_basic (97.79s)
=== CONT TestAccRoute53ResolverEndpoint_updateOutbound
--- PASS: TestAccRoute53ResolverEndpoint_disappears (158.10s)
=== CONT TestAccRoute53ResolverEndpoint_tags
--- PASS: TestAccRoute53ResolverEndpoint_tags (132.36s)
=== CONT TestAccRoute53ResolverEndpoint_basic
--- PASS: TestAccRoute53ResolverEndpoint_basic (106.66s)
=== CONT TestAccRoute53ResolverEndpointDataSource_filter
--- PASS: TestAccRoute53ResolverEndpoint_updateOutbound (345.18s)
--- PASS: TestAccRoute53ResolverEndpointDataSource_filter (237.53s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver 640.380s
@aristosvo Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds
protocols
as an option inaws_route53_resolver_endpoint
.Closes #35047
References
UpdateResolverEndpoint API
Output from Acceptance Testing