Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53_resolver_endpoint: add protocols #35098

Merged

Conversation

aristosvo
Copy link
Contributor

@aristosvo aristosvo commented Dec 31, 2023

Description

Adds protocols as an option in aws_route53_resolver_endpoint.

Closes #35047

References

UpdateResolverEndpoint API

Output from Acceptance Testing

% make testacc TESTS=TestAccRoute53ResolverEndpoint_updateOutbound PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverEndpoint_updateOutbound'  -timeout 360m
=== RUN   TestAccRoute53ResolverEndpoint_updateOutbound
=== PAUSE TestAccRoute53ResolverEndpoint_updateOutbound
=== CONT  TestAccRoute53ResolverEndpoint_updateOutbound
--- PASS: TestAccRoute53ResolverEndpoint_updateOutbound (386.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    388.899s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53resolver Issues and PRs that pertain to the route53resolver service. labels Dec 31, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 31, 2023
@aristosvo aristosvo changed the title aws_route53_resolver_endpoint: add protocols [WIP] r/aws_route53_resolver_endpoint: add protocols Dec 31, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @aristosvo 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Dec 31, 2023
@aristosvo aristosvo marked this pull request as ready for review January 1, 2024 10:09
@aristosvo aristosvo changed the title [WIP] r/aws_route53_resolver_endpoint: add protocols r/aws_route53_resolver_endpoint: add protocols Jan 1, 2024
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 3, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53ResolverEndpointDataSource_\|TestAccRoute53ResolverEndpoint_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2  -run=TestAccRoute53ResolverEndpointDataSource_\|TestAccRoute53ResolverEndpoint_ -timeout 360m
=== RUN   TestAccRoute53ResolverEndpointDataSource_basic
=== PAUSE TestAccRoute53ResolverEndpointDataSource_basic
=== RUN   TestAccRoute53ResolverEndpointDataSource_filter
=== PAUSE TestAccRoute53ResolverEndpointDataSource_filter
=== RUN   TestAccRoute53ResolverEndpoint_basic
=== PAUSE TestAccRoute53ResolverEndpoint_basic
=== RUN   TestAccRoute53ResolverEndpoint_disappears
=== PAUSE TestAccRoute53ResolverEndpoint_disappears
=== RUN   TestAccRoute53ResolverEndpoint_tags
=== PAUSE TestAccRoute53ResolverEndpoint_tags
=== RUN   TestAccRoute53ResolverEndpoint_updateOutbound
=== PAUSE TestAccRoute53ResolverEndpoint_updateOutbound
=== CONT  TestAccRoute53ResolverEndpointDataSource_basic
=== CONT  TestAccRoute53ResolverEndpoint_disappears
--- PASS: TestAccRoute53ResolverEndpointDataSource_basic (97.79s)
=== CONT  TestAccRoute53ResolverEndpoint_updateOutbound
--- PASS: TestAccRoute53ResolverEndpoint_disappears (158.10s)
=== CONT  TestAccRoute53ResolverEndpoint_tags
--- PASS: TestAccRoute53ResolverEndpoint_tags (132.36s)
=== CONT  TestAccRoute53ResolverEndpoint_basic
--- PASS: TestAccRoute53ResolverEndpoint_basic (106.66s)
=== CONT  TestAccRoute53ResolverEndpointDataSource_filter
--- PASS: TestAccRoute53ResolverEndpoint_updateOutbound (345.18s)
--- PASS: TestAccRoute53ResolverEndpointDataSource_filter (237.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	640.380s

@ewbankkit
Copy link
Contributor

@aristosvo Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8ed7b87 into hashicorp:main Jan 3, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 3, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon Route 53 Resolver Endpoints now supports DNS-over-HTTPS
2 participants