Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53_resolver_endpoint: add protocols #35098

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changelog/35098.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
```release-note:enhancement
resource/aws_route53_resolver_endpoint: Add `protocols` argument
```

```release-note:enhancement
data-source/aws_route53_resolver_endpoint: Add `protocols` attribute
```
45 changes: 37 additions & 8 deletions internal/service/route53resolver/endpoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,17 @@ func ResourceEndpoint() *schema.Resource {
MaxItems: 64,
Elem: &schema.Schema{Type: schema.TypeString},
},
"protocols": {
Type: schema.TypeSet,
Optional: true,
Computed: true,
MinItems: 1,
MaxItems: 2,
Elem: &schema.Schema{
Type: schema.TypeString,
ValidateFunc: validation.StringInSlice(route53resolver.Protocol_Values(), false),
},
},
names.AttrTags: tftags.TagsSchema(),
names.AttrTagsAll: tftags.TagsSchemaComputed(),
},
Expand Down Expand Up @@ -123,6 +134,10 @@ func resourceEndpointCreate(ctx context.Context, d *schema.ResourceData, meta in
input.Name = aws.String(v.(string))
}

if v, ok := d.GetOk("protocols"); ok && v.(*schema.Set).Len() > 0 {
input.Protocols = flex.ExpandStringSet(v.(*schema.Set))
}

output, err := conn.CreateResolverEndpointWithContext(ctx, input)

if err != nil {
Expand Down Expand Up @@ -158,6 +173,7 @@ func resourceEndpointRead(ctx context.Context, d *schema.ResourceData, meta inte
d.Set("direction", ep.Direction)
d.Set("host_vpc_id", ep.HostVPCId)
d.Set("name", ep.Name)
d.Set("protocols", aws.StringValueSlice(ep.Protocols))
d.Set("security_group_ids", aws.StringValueSlice(ep.SecurityGroupIds))

ipAddresses, err := findResolverEndpointIPAddressesByID(ctx, conn, d.Id())
Expand All @@ -176,11 +192,20 @@ func resourceEndpointRead(ctx context.Context, d *schema.ResourceData, meta inte
func resourceEndpointUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
conn := meta.(*conns.AWSClient).Route53ResolverConn(ctx)

if d.HasChange("name") {
_, err := conn.UpdateResolverEndpointWithContext(ctx, &route53resolver.UpdateResolverEndpointInput{
Name: aws.String(d.Get("name").(string)),
if d.HasChanges("name", "protocols") {
input := &route53resolver.UpdateResolverEndpointInput{
ResolverEndpointId: aws.String(d.Id()),
})
}

if d.HasChange("name") {
input.Name = aws.String(d.Get("name").(string))
}

if d.HasChange("protocols") {
input.Protocols = flex.ExpandStringSet(d.Get("protocols").(*schema.Set))
}

_, err := conn.UpdateResolverEndpointWithContext(ctx, input)

if err != nil {
return diag.Errorf("updating Route53 Resolver Endpoint (%s): %s", d.Id(), err)
Expand All @@ -200,10 +225,12 @@ func resourceEndpointUpdate(ctx context.Context, d *schema.ResourceData, meta in

// Add new before deleting old so number of IP addresses doesn't drop below 2.
for _, v := range add {
_, err := conn.AssociateResolverEndpointIpAddressWithContext(ctx, &route53resolver.AssociateResolverEndpointIpAddressInput{
input := &route53resolver.AssociateResolverEndpointIpAddressInput{
IpAddress: expandEndpointIPAddressUpdate(v),
ResolverEndpointId: aws.String(d.Id()),
})
}

_, err := conn.AssociateResolverEndpointIpAddressWithContext(ctx, input)

if err != nil {
return diag.Errorf("associating Route53 Resolver Endpoint (%s) IP address: %s", d.Id(), err)
Expand All @@ -215,10 +242,12 @@ func resourceEndpointUpdate(ctx context.Context, d *schema.ResourceData, meta in
}

for _, v := range del {
_, err := conn.DisassociateResolverEndpointIpAddressWithContext(ctx, &route53resolver.DisassociateResolverEndpointIpAddressInput{
input := &route53resolver.DisassociateResolverEndpointIpAddressInput{
IpAddress: expandEndpointIPAddressUpdate(v),
ResolverEndpointId: aws.String(d.Id()),
})
}

_, err := conn.DisassociateResolverEndpointIpAddressWithContext(ctx, input)

if err != nil {
return diag.Errorf("disassociating Route53 Resolver Endpoint (%s) IP address: %s", d.Id(), err)
Expand Down
6 changes: 6 additions & 0 deletions internal/service/route53resolver/endpoint_data_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ func DataSourceEndpoint() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},
"protocols": {
Type: schema.TypeSet,
Elem: &schema.Schema{Type: schema.TypeString},
Computed: true,
},
"resolver_endpoint_id": {
Type: schema.TypeString,
Optional: true,
Expand Down Expand Up @@ -115,6 +120,7 @@ func dataSourceEndpointRead(ctx context.Context, d *schema.ResourceData, meta in
d.Set("arn", ep.Arn)
d.Set("direction", ep.Direction)
d.Set("name", ep.Name)
d.Set("protocols", aws.StringValueSlice(ep.Protocols))
d.Set("resolver_endpoint_id", ep.Id)
d.Set("status", ep.Status)
d.Set("vpc_id", ep.HostVPCId)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ func TestAccRoute53ResolverEndpointDataSource_basic(t *testing.T) {
resource.TestCheckResourceAttrPair(datasourceName, "id", resourceName, "id"),
resource.TestCheckResourceAttrPair(datasourceName, "ip_addresses.#", resourceName, "ip_address.#"),
resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
resource.TestCheckResourceAttrPair(datasourceName, "protocols.#", resourceName, "protocols.#"),
resource.TestCheckResourceAttrPair(datasourceName, "resolver_endpoint_id", resourceName, "id"),
resource.TestCheckResourceAttrPair(datasourceName, "vpc_id", resourceName, "host_vpc_id"),
),
Expand Down
5 changes: 5 additions & 0 deletions internal/service/route53resolver/endpoint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ func TestAccRoute53ResolverEndpoint_basic(t *testing.T) {
resource.TestCheckResourceAttrPair(resourceName, "host_vpc_id", vpcResourceName, "id"),
resource.TestCheckResourceAttr(resourceName, "ip_address.#", "3"),
resource.TestCheckResourceAttr(resourceName, "name", ""),
resource.TestCheckResourceAttr(resourceName, "protocols.#", "1"),
resource.TestCheckResourceAttr(resourceName, "security_group_ids.#", "2"),
resource.TestCheckResourceAttr(resourceName, "tags.%", "0"),
),
Expand Down Expand Up @@ -144,6 +145,7 @@ func TestAccRoute53ResolverEndpoint_updateOutbound(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "direction", "OUTBOUND"),
resource.TestCheckResourceAttr(resourceName, "ip_address.#", "2"),
resource.TestCheckResourceAttr(resourceName, "name", initialName),
resource.TestCheckResourceAttr(resourceName, "protocols.#", "1"),
),
},
{
Expand All @@ -153,6 +155,7 @@ func TestAccRoute53ResolverEndpoint_updateOutbound(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "direction", "OUTBOUND"),
resource.TestCheckResourceAttr(resourceName, "ip_address.#", "3"),
resource.TestCheckResourceAttr(resourceName, "name", updatedName),
resource.TestCheckResourceAttr(resourceName, "protocols.#", "2"),
),
},
},
Expand Down Expand Up @@ -377,6 +380,8 @@ resource "aws_route53_resolver_endpoint" "test" {
ip_address {
subnet_id = aws_subnet.test[0].id
}

protocols = ["Do53", "DoH"]
}
`, name))
}
1 change: 1 addition & 0 deletions website/docs/d/route53_resolver_endpoint.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ In addition to all arguments above, the following attributes are exported:
* `arn` - Computed ARN of the Route53 Resolver Endpoint.
* `direction` - Direction of the queries to or from the Resolver Endpoint .
* `ip_addresses` - List of IPaddresses that have been associated with the Resolver Endpoint.
* `protocols` - The protocols used by Resolver endpoint.
* `status` - Current status of the Resolver Endpoint.
* `vpc_id` - ID of the Host VPC that the Resolver Endpoint resides in.

Expand Down
3 changes: 3 additions & 0 deletions website/docs/r/route53_resolver_endpoint.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ resource "aws_route53_resolver_endpoint" "foo" {
ip = "10.0.64.4"
}

protocols = ["Do53", "DoH"]

tags = {
Environment = "Prod"
}
Expand All @@ -48,6 +50,7 @@ or `OUTBOUND` (resolver forwards DNS queries from the DNS service for a VPC to y
to your network (for outbound endpoints) or on the way from your network to your VPCs (for inbound endpoints). Described below.
* `security_group_ids` - (Required) The ID of one or more security groups that you want to use to control access to this VPC.
* `name` - (Optional) The friendly name of the Route 53 Resolver endpoint.
* `protocols` - (Optional) The protocols you want to use for the Route 53 Resolver endpoint. Valid values: `DoH`, `Do53`, `DoH-FIPS`.
* `tags` - (Optional) A map of tags to assign to the resource. If configured with a provider [`default_tags` configuration block](https://registry.terraform.io/providers/hashicorp/aws/latest/docs#default_tags-configuration-block) present, tags with matching keys will overwrite those defined at the provider-level.

The `ip_address` object supports the following:
Expand Down
Loading