-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_route53_resolver_rule
: add protocols
#35744
r/aws_route53_resolver_rule
: add protocols
#35744
Conversation
Community NoteVoting for Prioritization
For Submitters
|
24094bd
to
fc86097
Compare
fc86097
to
3dc2370
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRoute53ResolverRule_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2 -run=TestAccRoute53ResolverRule_ -timeout 360m
=== RUN TestAccRoute53ResolverRule_basic
=== PAUSE TestAccRoute53ResolverRule_basic
=== RUN TestAccRoute53ResolverRule_disappears
=== PAUSE TestAccRoute53ResolverRule_disappears
=== RUN TestAccRoute53ResolverRule_tags
=== PAUSE TestAccRoute53ResolverRule_tags
=== RUN TestAccRoute53ResolverRule_justDotDomainName
=== PAUSE TestAccRoute53ResolverRule_justDotDomainName
=== RUN TestAccRoute53ResolverRule_trailingDotDomainName
=== PAUSE TestAccRoute53ResolverRule_trailingDotDomainName
=== RUN TestAccRoute53ResolverRule_updateName
=== PAUSE TestAccRoute53ResolverRule_updateName
=== RUN TestAccRoute53ResolverRule_forward
=== PAUSE TestAccRoute53ResolverRule_forward
=== RUN TestAccRoute53ResolverRule_forwardMultiProtocol
=== PAUSE TestAccRoute53ResolverRule_forwardMultiProtocol
=== RUN TestAccRoute53ResolverRule_forwardEndpointRecreate
=== PAUSE TestAccRoute53ResolverRule_forwardEndpointRecreate
=== CONT TestAccRoute53ResolverRule_basic
=== CONT TestAccRoute53ResolverRule_updateName
--- PASS: TestAccRoute53ResolverRule_basic (22.56s)
=== CONT TestAccRoute53ResolverRule_justDotDomainName
--- PASS: TestAccRoute53ResolverRule_updateName (35.91s)
=== CONT TestAccRoute53ResolverRule_trailingDotDomainName
--- PASS: TestAccRoute53ResolverRule_justDotDomainName (19.87s)
=== CONT TestAccRoute53ResolverRule_tags
--- PASS: TestAccRoute53ResolverRule_trailingDotDomainName (19.03s)
=== CONT TestAccRoute53ResolverRule_disappears
--- PASS: TestAccRoute53ResolverRule_disappears (16.17s)
=== CONT TestAccRoute53ResolverRule_forwardMultiProtocol
--- PASS: TestAccRoute53ResolverRule_tags (42.24s)
=== CONT TestAccRoute53ResolverRule_forwardEndpointRecreate
--- PASS: TestAccRoute53ResolverRule_forwardMultiProtocol (273.99s)
=== CONT TestAccRoute53ResolverRule_forward
--- PASS: TestAccRoute53ResolverRule_forwardEndpointRecreate (438.26s)
--- PASS: TestAccRoute53ResolverRule_forward (273.43s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver 628.441s
This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
target_ip.protocol
parameter added to select aprotocol
for multiprotocol endpoints.Relations
Closes #35733
References
#35098
Output from Acceptance Testing