Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more notes about hcl2 compatibility #9634

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Dec 14, 2020

Make backward compatibility notes about Task Driver config options. Namely, call out the use of blocks with non-identifier attributes (like in docker systctl and storage_options) or nesting block syntax within an attribute assignment. Neither of these are valid HCL2. The solution is relatively simple: We can add = and quote the non-identifier attribute names.

Related to #9604 .

@notnoop notnoop requested a review from tgross December 14, 2020 21:44
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just some capitalization/syntax fixes

website/pages/docs/job-specification/hcl2/index.mdx Outdated Show resolved Hide resolved
website/pages/docs/job-specification/hcl2/index.mdx Outdated Show resolved Hide resolved
website/pages/docs/job-specification/hcl2/index.mdx Outdated Show resolved Hide resolved
Co-authored-by: Tim Gross <[email protected]>
@notnoop notnoop merged commit 0993d5c into master Dec 14, 2020
@notnoop notnoop deleted the docs-hcl2-tweaks-20201214 branch December 14, 2020 22:07
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants