unexpected behavior with docker -> volume_options and hcl2

[MorphBonehunter]

Nomad version

Nomad v1.0.0 (cfca640)

Operating system and Environment details

ArchLinux

Issue

The docker "volume_options" parameter and sub-parameter which are mentioned in the Docs doesn't work with the hcl2 parser in the form mentioned there.
This happens to me after upgrading to 1.0 of nomad and try to resubmit an existing job with this option.
I can use the -hcl1 option and it works but the mentioned fix for not using this option isn't appropriate.

Reproduction steps

• upgrade nomad to v1.0
• re-submit an job with the docker volume_options set

Job file (if appropriate)

original job file sniped:

...
          {
            type = "volume"
            source = "media"
            target = "/media"
            volume_options {
              driver_config {
                name = "local"
                options = {
                  type = "nfs4"
                  o = "addr=192.168.200.10,vers=4.2,noatime"
                  device = "192.168.200.10:/media"
                }
              }
            }
          }
...

error message while submitting:

Error getting job struct: Failed to parse using HCL 2. Use the HCL 1 parser with `nomad run -hcl1`, or address the following issues:
minidlna.job.generated:45,25-26: Missing key/value separator; Expected an equals sign ("=") to mark the beginning of the attribute value.
Error getting job struct: Failed to parse using HCL 2. Use the HCL 1 parser with `nomad run -hcl1`, or address the following issues:
minidlna.job.generated:45,25-26: Missing key/value separator; Expected an equals sign ("=") to mark the beginning of the attribute value.

I can fix this with the -hcl1 option while submitting.
If i add the mentioned equals signs and resulting in the following job snipped:

...
          {
            type = "volume"
            source = "media"
            target = "/media"
            volume_options = {
              driver_config = {
                name = "local"
                options = {
                  type = "nfs4"
                  o = "addr=192.168.200.10,vers=4.2,noatime"
                  device = "192.168.200.10:/media"
                }
              }
            }
          }
...

i can submitt this job without the -hcl1 option, but the job doesn't run with an error:

Failed Validation | 2 errors occurred: * failed to parse config: * Incorrect attribute value type: Inappropriate value for attribute "options": list of map of string required.

So after some try and error i ended with the following job snipped which worked (submitting and running):

...
          {
            type = "volume"
            source = "media"
            target = "/media"
            volume_options = [
              {
                driver_config = [
                  {
                    name = "local"
                    options = [
                      {
                        type = "nfs4"
                        o = "addr=192.168.200.10,vers=4.2,noatime"
                        device = "192.168.200.10:/media"
                      }
                    ]
                  }
                ]
              }
            ]
          }
...

resulting diff:

             type = "volume"
             source = "media"
             target = "/media"
-            volume_options {
-              driver_config {
-                name = "local"
-                options = {
-                  type = "nfs4"
-                  o = "addr=192.168.200.10,vers=4.2,noatime"
-                  device = "192.168.200.10:/media"
-                }
+            volume_options = [
+              {
+                driver_config = [
+                  {
+                    name = "local"
+                    options = [
+                      {
+                        type = "nfs4"
+                        o = "addr=192.168.200.10,vers=4.2,noatime"
+                        device = "192.168.200.10:/media"
+                      }
+                    ]
+                  }
+                ]
               }
-            }
+            ]
           }
         ]

Is this the intended behavior or is it an bug?
The Doku doesn't mentioned the new behavior with hcl2 or the changed syntax.

[notnoop]

Thanks @MorphBonehunter for reaching out. This is indeed a bug and isn't an intended change. We'll investigate and follow up with a fix soon.

[MorphBonehunter]

I've migrate to the new "mount" syntax and it worked like expected (and is much nicer than before i think 😄).
Maybe it's worth to mention this on the Upgrade Guide?
I've seen this was an mentioned "task" in #9635.

[MorphBonehunter]

I think we can close this as the problem was solved long ago 👍

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.