Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: consul-template v0.25.1 #8716

Closed
wants to merge 5 commits into from
Closed

vendor: consul-template v0.25.1 #8716

wants to merge 5 commits into from

Conversation

greut
Copy link
Contributor

@greut greut commented Aug 23, 2020

consult-template v0.25.1 adopted allow/denylist nomenclature, hashicorp/consul-template#1388 - it's probably a good time to follow.

notnoop
notnoop reviewed Aug 24, 2020
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Changing the nomenclature to be inclusive is ongoing effort that we pushing for across HashiCorp products - See https://discuss.hashicorp.com/t/inclusive-language-changes/12797 .

I think we (the Nomad team) intends to adopt these changes while keeping backward compatibility, where we go through a deprecation cycle. I will review the PR in closer detail soon. Thank you so much again.

client/fingerprint_manager.go Outdated Show resolved Hide resolved
@greut greut force-pushed the consul-template-v0.25.1 branch from 650b6ef to 5c0ea44 Compare August 24, 2020 19:52
@tgross
Copy link
Member

tgross commented Oct 2, 2020

Closing in lieu of #8988

@tgross tgross closed this Oct 2, 2020
@greut
Copy link
Contributor Author

greut commented Oct 3, 2020

@tgross @notnoop 🤷‍♂️ !?

@greut greut mentioned this pull request Oct 3, 2020
Merged
@tgross
Copy link
Member

tgross commented Oct 5, 2020

@tgross @notnoop 🤷‍♂️ !?

Yeah, sorry about that... I was reviewing someone else's work on updating consul-template to support Consul Namespaces, and didn't realize that we had an in-flight PR open. A bit of a miscommunication over here among the Nomad reviewers.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notnoop notnoop notnoop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greut @tgross @notnoop