-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update consul-template to v0.25.1 #8988
Conversation
898ee3d
to
017bb60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fredrikhgrelland! Thanks so much for this PR, especially for pulling out the consul-template change from the large PR you're working on.
This isn't a blocker but would help testing: to test backwards compatibility, I ran a job on a build from master
, then built this PR and restarted Nomad. Unfortunately I got a panic when restarting Nomad with the new build (see below). If I wipe out the data dir and run with this build, it works fine. And when I rebased this PR on master the problem and started over from scratch the problem went away... there's probably something that landed on master that you don't have in your branch that's breaking raft entries, so if you were to rebase from master that would make it easier to test this out. Thanks!
Started Nomad.
==> WARNING: Bootstrap mode enabled! Potentially unsafe operation.
==> Loaded configuration from /etc/nomad.d/standalone.hcl
==> Starting Nomad agent...
panic: failed to apply request: []byte{0x48, 0x81, 0xaa, 0x43, 0x72, 0x65, 0x61, 0x74, 0x65, 0x54, 0x69, 0x6d, 0x65, 0xd3, 0x16, 0x39, 0xdd, 0xcf, 0x8d, 0x5b, 0xd7, 0xf9}
goroutine 16 [running]:
github.com/hashicorp/nomad/nomad.(*nomadFSM).Apply(0xc0002d73b0, 0xc0005d0aa0, 0x4f8ad20, 0xbfd590b12b50cc03)
github.com/hashicorp/nomad/nomad/fsm.go:292 +0x193b
github.com/hashicorp/raft.(*Raft).runFSM.func1(0xc00007cac0)
github.com/hashicorp/[email protected]/fsm.go:90 +0x2c1
github.com/hashicorp/raft.(*Raft).runFSM.func2(0xc000212000, 0x33, 0x40)
github.com/hashicorp/[email protected]/fsm.go:113 +0x75
github.com/hashicorp/raft.(*Raft).runFSM(0xc0005f4000)
github.com/hashicorp/[email protected]/fsm.go:219 +0x42f
github.com/hashicorp/raft.(*raftState).goFunc.func1(0xc0005f4000, 0xc0003d6c00)
github.com/hashicorp/[email protected]/state.go:146 +0x55
created by github.com/hashicorp/raft.(*raftState).goFunc
github.com/hashicorp/[email protected]/state.go:144 +0x66
017bb60
to
13eb8e3
Compare
13eb8e3
to
bb2a2c3
Compare
Rebased from master and ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked out the rebase PR and tested it out and everything looks great! 👍
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
While working on #8849 I needed consul namespace support in consul-template.
Inclusive language changes required some refactoring, but is kept backwards compatible.