multiregion: all regions start in running if no max_parallel #8209
Conversation
If `max_parallel` is not set, all regions should begin in a `running` state rather than a `pending` state. Otherwise the first region is set to `running` and then all the remaining regions once it enters `blocked. That behavior is technically correct in that we have at most `max_parallel` regions running, but definitely not what a user expects.
| @@ -198,7 +198,6 @@ func (a *allocReconciler) Compute() *reconcileResults { | |||
| // Detect if the deployment is paused | |||
| if a.deployment != nil { | |||
| a.deploymentPaused = a.deployment.Status == structs.DeploymentStatusPaused | |||
| //|| a.deployment.Status == structs.DeploymentStatusPending | |||
scheduler/reconcile.go
Outdated
| // region starts in the running state | ||
| if a.job.IsMultiregion() && | ||
| a.job.Multiregion.Strategy != nil && | ||
| a.job.Multiregion.Strategy.MaxParallel != 0 && |
There was a problem hiding this comment.
I missed some of the changes of PRs - do we also want to check MaxParallel against current region index (e.g. second region with MaxParallel=2); is that handled elsewhere?
There was a problem hiding this comment.
Oh that's a good catch. That's the same sort of thing -- we'd safely have at most max_parallel going, but the operator probably expects us to start with max_parallel. Will fix.
There was a problem hiding this comment.
The logic here is getting gnarly though so I'm going to pull it out into a function.
There was a problem hiding this comment.
I've pulled this logic out to a function on Job in f10cc93
In #8209 we fixed the max_parallel stanza for multiregion by introducing the IsMultiregionStarter check, but didn't apply it to the earlier place its required. The result is that deployments start but don't place allocations.
In #8209 we fixed the `max_parallel` stanza for multiregion by introducing the `IsMultiregionStarter` check, but didn't apply it to the earlier place its required. The result is that deployments start but don't place allocations.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
If
max_parallelis not set, all regions should begin in arunningstaterather than a
pendingstate. Otherwise the first region is set torunningand then all the remaining regions once it enters
blocked. That behavior istechnically correct in that we have at most
max_parallelregions running,but definitely not what a user expects.