Skip to content

Commit

Permalink
multiregion: initial deploymentPaused must match start condition (#8215)
Browse files Browse the repository at this point in the history
In #8209 we fixed the `max_parallel` stanza for multiregion by introducing the
`IsMultiregionStarter` check, but didn't apply it to the earlier place its
required. The result is that deployments start but don't place allocations.
  • Loading branch information
tgross authored Jun 19, 2020
1 parent fcf08db commit 1916051
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scheduler/reconcile.go
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ func (a *allocReconciler) Compute() *reconcileResults {
// When we create the deployment later, it will be in a paused
// state. But we also need to tell Compute we're paused, otherwise we
// make placements on the paused deployment.
if a.job.IsMultiregion() && a.job.Region != a.job.Multiregion.Regions[0].Name {
if !a.job.IsMultiregionStarter() {
a.deploymentPaused = true
}
}
Expand Down

0 comments on commit 1916051

Please sign in to comment.