skip check for advertise address for http and rpc in client mode

[tantra35]

This is may be useful when we set bind addr to 127.0.0.1(localhost) when nomad in client mode, and consul.auto_advertise was set into false

Due new nomad rpc communication, its not necessary bind to 0.0.0.0 in client mode, and when nomad agent doiens't advertise him by consul, so we can set bind addr to localhost, but without this patch nomad doesn't start with error:

Failed to parse HTTP advertise address (, 127.0.0.1, 4646, false): Defaulting advertise to localhost is unsafe, please set advertise manually

But this is wrong

[tgross]

Hi @tantra35! I'm going through and reviewing some of these open PRs.

I'm not totally sure I understand the scenario we're trying to avoid here... can you provide an example client configuration that you think should be ok but is triggering the error message?

[glennschmidt]

I tried to start a client using the example client config here:
https://github.com/hashicorp/nomad/blob/master/dist/client.hcl
and it failed with the error described above ('defaulting advertise to localhost is unsafe').

To get it to start, I had to change bind_addr = "127.0.0.1" to bind_addr = "0.0.0.0"

Given that it's functioning as a client, it's not obvious to me why it would need to 'advertise' or why it would need to listen for connections on a public interface?

[tgross]

Doing some issue triage cleanup... going to close this one out.

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.