skip check for advertise address for http and rpc in client mode. #4678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is may be useful when we set bind addr to 127.0.0.1(localhost) when nomad in client mode, and consul.auto_advertise was set into false
Due new nomad rpc communication, its not necessary bind to 0.0.0.0 in client mode, and when nomad agent doiens't advertise him by consul, so we can set bind addr to localhost, but without this patch nomad doesn't start with error:
But this is wrong