Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit logs on SIGPIPE since logging service could be unavailable #3555

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Do not emit logs on SIGPIPE since logging service could be unavailable #3555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions command/agent/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,13 +548,14 @@ WAIT:
case <-c.retryJoinErrCh:
return 1
}
c.Ui.Output(fmt.Sprintf("Caught signal: %v", sig))

// Skip any SIGPIPE signal (See issue #1798)
// Skip any SIGPIPE signal and don't try to log it (See issues #1798, #3554)
if sig == syscall.SIGPIPE {
goto WAIT
}

c.Ui.Output(fmt.Sprintf("Caught signal: %v", sig))

// Check if this is a SIGHUP
if sig == syscall.SIGHUP {
c.handleReload()
Expand Down