Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit logs on SIGPIPE since logging service could be unavailable #3555

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Do not emit logs on SIGPIPE since logging service could be unavailable #3555

merged 1 commit into from
Dec 4, 2017

Conversation

maxvt
Copy link

@maxvt maxvt commented Nov 15, 2017

This should fix #3554

@dadgar
Copy link
Contributor

dadgar commented Nov 16, 2017

@maxvt Have you built and tried this change? If so it looks good! Want to confirm it fixes the problem first though!

@maxvt
Copy link
Author

maxvt commented Nov 20, 2017

Haven't built it yet. I'm away from work for a few days, I'll try it (backported to the version we run) once I'm back.

@maxvt
Copy link
Author

maxvt commented Nov 22, 2017

@dadgar I built and tested it, nothing seems to break but I couldn't reproduce the original problem we had either -- I could stop journald on the test box and Consul would freak out but Nomad stayed at low CPU. Up to you if you want to pick this up or close.

@dadgar dadgar merged commit f8807ce into hashicorp:master Dec 4, 2017
@dadgar
Copy link
Contributor

dadgar commented Dec 4, 2017

Thanks for following up @maxvt!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restarting journald causes Nomad to get stuck in a loop with high CPU usage
3 participants