Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: add support for wildcard namespaces on plugin status #20551

Merged
merged 2 commits into from
May 13, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented May 9, 2024

The nomad plugin status :plugin_id command lists allocations that implement the plugin being queried. This list is filtered by the -namespace flag as usual. Cluster admins will likely deploy plugins to a single namespace, but for convenience they may want to have the wildcard namespace set in their command environment.

Add support for handling the wildcard namespace to the CSI plugin RPC handler.

Fixes: #20537

The `nomad plugin status :plugin_id` command lists allocations that implement
the plugin being queried. This list is filtered by the `-namespace` flag as
usual. Cluster admins will likely deploy plugins to a single namespace, but for
convenience they may want to have the wildcard namespace set in their command
environment.

Add support for handling the wildcard namespace to the CSI plugin RPC handler.

Fixes: #20537
@tgross tgross force-pushed the csi-plugin-wildcard branch from 2b80d5b to 1b1cfde Compare May 9, 2024 19:07
@tgross tgross changed the title csi: add support for wildcard namespaces on plugin status CSI: add support for wildcard namespaces on plugin status May 9, 2024
@tgross tgross added this to the 1.8.0 milestone May 9, 2024
@tgross tgross marked this pull request as ready for review May 9, 2024 19:20
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from the println, lgtm!

nomad/csi_endpoint.go Outdated Show resolved Hide resolved
Co-authored-by: Daniel Bennett <[email protected]>
@tgross tgross merged commit 5b328d9 into main May 13, 2024
1 of 9 checks passed
@tgross tgross deleted the csi-plugin-wildcard branch May 13, 2024 19:42
Copy link

github-actions bot commented Jan 9, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support wildcard namespace for allocs in nomad plugin status :plugin_id
2 participants