Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support wildcard namespace for allocs in nomad plugin status :plugin_id #20537

Closed
tgross opened this issue May 7, 2024 · 1 comment · Fixed by #20551
Closed

support wildcard namespace for allocs in nomad plugin status :plugin_id #20537

tgross opened this issue May 7, 2024 · 1 comment · Fixed by #20551
Assignees
@tgross
Labels
theme/cli theme/storage type/enhancement
Milestone
1.8.0

Comments

@tgross
Copy link
Member

tgross commented May 7, 2024 •
edited
Loading

The nomad plugin status :plugin_id command lists allocations that implement the plugin being queried. Cluster admins will likely deploy plugins to a dedicated namespace, but the command doesn't support the wildcard namespace:

$ nomad plugin status -namespace '*' org.demo
ID                   = org.democratic-csi.nfs
Provider             = org.democratic-csi.nfs
Version              = 1.9.0
Controllers Healthy  = 2
Controllers Expected = 2
Nodes Healthy        = 3
Nodes Expected       = 3

Allocations
No allocations placed

Compare to when passing a specific namespace:

$ nomad plugin status -namespace plugins org.demo
ID                   = org.democratic-csi.nfs
Provider             = org.democratic-csi.nfs
Version              = 1.9.0
Controllers Healthy  = 2
Controllers Expected = 2
Nodes Healthy        = 3
Nodes Expected       = 3

Allocations
ID        Node ID   Task Group  Version  Desired  Status   Created    Modified
295a2da3  8806d811  nodes       2        run      running  5m29s ago  5m11s ago
47ab2f03  8806d811  controller  3        run      running  5m25s ago  5m11s ago
903d2e83  a6afad7d  controller  3        run      running  5m25s ago  5m14s ago
17941b89  a6afad7d  nodes       2        run      running  5m29s ago  5m18s ago
ed0cf94c  74c50d77  nodes       2        run      running  5m29s ago  5m18s ago
@tgross tgross mentioned this issue May 9, 2024
Merged
tgross added a commit that referenced this issue May 9, 2024
@tgross
csi: add support for wildcard namespaces on plugin status
1b1cfde 
The `nomad plugin status :plugin_id` command lists allocations that implement
the plugin being queried. This list is filtered by the `-namespace` flag as
usual. Cluster admins will likely deploy plugins to a single namespace, but for
convenience they may want to have the wildcard namespace set in their command
environment.

Add support for handling the wildcard namespace to the CSI plugin RPC handler.

Fixes: #20537
@tgross tgross added this to the 1.8.0 milestone May 9, 2024
@tgross tgross self-assigned this May 9, 2024
tgross added a commit that referenced this issue May 13, 2024
@tgross
CSI: add support for wildcard namespaces on plugin status (#20551)
5b328d9 
The `nomad plugin status :plugin_id` command lists allocations that implement
the plugin being queried. This list is filtered by the `-namespace` flag as
usual. Cluster admins will likely deploy plugins to a single namespace, but for
convenience they may want to have the wildcard namespace set in their command
environment.

Add support for handling the wildcard namespace to the CSI plugin RPC handler.

Fixes: #20537
@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tgross tgross

Labels
theme/cli theme/storage type/enhancement
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

CSI: add support for wildcard namespaces on plugin status hashicorp/nomad
1 participant
@tgross