Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: set default envoy version domain #17045

Merged
merged 1 commit into from
May 2, 2023
Merged

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented May 1, 2023

This PR modifies references to the envoyproxy/envoy docker image to
explicitly include the docker.io prefix. This does not affect existing
[docker] users, but makes things easier for Podman users, who otherwise need to
specify the full name because Podman does not default to docker.io

@shoenig shoenig force-pushed the default-envoy-version-domain branch from 438215a to 7d4056e Compare May 1, 2023 18:59
@shoenig shoenig changed the title default envoy version domain connect: set default envoy version domain May 1, 2023
@shoenig shoenig added this to the 1.6.0 milestone May 1, 2023
@shoenig shoenig force-pushed the default-envoy-version-domain branch from 7d4056e to a3af0ed Compare May 2, 2023 13:55
This PR modifies references to the envoyproxy/envoy docker image to
explicitly include the docker.io prefix. This does not affect existing
users, but makes things easier for Podman users, who otherwise need to
specify the full name because Podman does not default to docker.io
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shoenig shoenig merged commit 7744cae into main May 2, 2023
@shoenig shoenig deleted the default-envoy-version-domain branch May 2, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants