You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running the envoy connect sidecar as a podman job, one currently needs to configure the image manually, partly due to #17040 and partly because the image name needs to be prefixed with docker.io/.
Ideally, podman oriented clusters could use Connect jobs just like docker oriented clusters, where the connect{} block by default Just Works.
This PR adds a heuristic to detect whether to use the podman task driver
for the connect sidecar proxy. The podman driver will be selected if there
is at least one task in the task group configured to use podman, and there
are zero tasks in the group configured to use docker. In all other cases
the task driver defaults to docker.
After this change, we should be able to run typical Connect jobspecs
(e.g. nomad job init [-short] -connect) on Clusters configured with the
podman task driver, without modification to the job files.
Closes#17042
* connect: use heuristic to detect sidecar task driver
This PR adds a heuristic to detect whether to use the podman task driver
for the connect sidecar proxy. The podman driver will be selected if there
is at least one task in the task group configured to use podman, and there
are zero tasks in the group configured to use docker. In all other cases
the task driver defaults to docker.
After this change, we should be able to run typical Connect jobspecs
(e.g. nomad job init [-short] -connect) on Clusters configured with the
podman task driver, without modification to the job files.
Closes#17042
* golf: cleanup driver detection logic
When running the envoy connect sidecar as a podman job, one currently needs to configure the
image
manually, partly due to #17040 and partly because the image name needs to be prefixed withdocker.io/
.Ideally, podman oriented clusters could use Connect jobs just like docker oriented clusters, where the
connect{}
block by default Just Works.Incorporates
The text was updated successfully, but these errors were encountered: