nomad: fix race in Bootstrapped access #14120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
force-pushed
the
b-race-bootstrapped
branch
from
7fdf9f6 to
befadbc
Compare
schmichael
force-pushed
the
b-race-bootstrapped
branch
from
94d7333 to
e0adc6d
Compare
|
Rebased to get Go 1.19 from #14132 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2/n of my effort to make agent tests race free. (Prev: #14119)
I gave up on an initial effort of refactoring serf interactions out of Server because it was just going to be too big of a distraction at the moment. I think that's the eventual direction we should head (if we don't just remove serf entirely).